You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by Vr Vlaa <vi...@gmail.com> on 2020/03/27 12:14:56 UTC
Fwd: [apache/skywalking] Provide ability to turn off plugins (#4578)
---------- Forwarded message ---------
From: 吴晟 Wu Sheng <no...@github.com>
Date: Fri, Mar 27, 2020 at 7:47 AM
Subject: Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
To: apache/skywalking <sk...@noreply.github.com>
Cc: viswaramamoorthy <vi...@gmail.com>, Author <
author@noreply.github.com>
I prefer you still use the agent.config to deactivate, by listing the
disable plugin names. You should notice all plugin.def includes names, You
should use those names to disable agent plugins.
WDYT?
And, this discussion should happen in the mail list, could you forward
there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/apache/skywalking/issues/4578#issuecomment-604957166>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA>
.
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Sheng Wu <wu...@gmail.com>.
Hi Viswa
Add you to the receiver list. I recommend you to subscribe the mail list,
in case you missed the reply.
Mail to dev-subscribe@skywalking.apache.org
Sheng Wu <wu...@apache.org>于2020年3月30日 周一下午8:56写道：
> Inline.
>
> Viswa Ramamoorthy <vi...@gmail.com>于2020年3月30日 周一下午8:52写道：
>
>> Yes. I gave have seen it. But in a release plugin keys would stay the
>> same.
>> Right?
>
>
> The only case I know, which has the name changed, is due to adopting new
> version of libraries. So, They change the existing plugin name, such as
> adding the latest version number in the name.
> But still, this is not a normal case.
>
>
>>
>> Ideally plugins could be given a ID that can be a separate enhancement in
>> a
>> new release.
>
>
> I think basically, It is still same. Because people can't predict the
> future, can't tell which part of the plugin would be incompatible.😂
>
>
>>
>> On Mon, Mar 30, 2020, 6:25 AM kezhenxu94 <ke...@163.com> wrote:
>>
>> >
>> >
>> > > 在 2020年3月27日，20:25，Sheng Wu <wu...@apache.org> 写道：
>> > >
>> > > Hi Dev team
>> > >
>> > > There is a discussion happening on GitHub issue. I hope that could
>> > continue
>> > > on the mail list.
>> > >
>> > > Vr Vlaa wants to add a mechanism to disable plugin without physical
>> > > deletion. I propose to keep using agent.config file and the names in
>> the
>> > > plugin.def files.
>> > >
>> >
>> > It’s ok to use the key in .def files, but as a reminder, the keys are
>> not
>> > strict rules and is subject to change
>> >
>> > > I want to hear more from others from dev team.
>> > >
>> > > Sheng Wu
>> > >
>> > > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
>> > >
>> > >> ---------- Forwarded message ---------
>> > >> From: 吴晟 Wu Sheng <no...@github.com>
>> > >> Date: Fri, Mar 27, 2020 at 7:47 AM
>> > >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
>> > >> (#4578)
>> > >> To: apache/skywalking <sk...@noreply.github.com>
>> > >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
>> > >> author@noreply.github.com>
>> > >>
>> > >>
>> > >> I prefer you still use the agent.config to deactivate, by listing the
>> > >> disable plugin names. You should notice all plugin.def includes
>> names,
>> > You
>> > >> should use those names to disable agent plugins.
>> > >>
>> > >> WDYT?
>> > >>
>> > >> And, this discussion should happen in the mail list, could you
>> forward
>> > >> there?
>> > >>
>> > >> —
>> > >> You are receiving this because you authored the thread.
>> > >> Reply to this email directly, view it on GitHub
>> > >> <
>> > https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
>> >,
>> > >> or unsubscribe
>> > >> <
>> > >>
>> >
>> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
>> > >>>
>> > >> .
>> > >>
>> > > --
>> > > Sheng Wu 吴晟
>> > >
>> > > Apache SkyWalking
>> > > Apache Incubator
>> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
>> > > Zipkin
>> > > Twitter, wusheng1108
>> > >
>> >
>> >
>> >
>>
> --
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
--
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Sheng Wu <wu...@apache.org>.
Inline.
Viswa Ramamoorthy <vi...@gmail.com>于2020年3月30日 周一下午8:52写道：
> Yes. I gave have seen it. But in a release plugin keys would stay the same.
> Right?
The only case I know, which has the name changed, is due to adopting new
version of libraries. So, They change the existing plugin name, such as
adding the latest version number in the name.
But still, this is not a normal case.
>
> Ideally plugins could be given a ID that can be a separate enhancement in a
> new release.
I think basically, It is still same. Because people can't predict the
future, can't tell which part of the plugin would be incompatible.😂
>
> On Mon, Mar 30, 2020, 6:25 AM kezhenxu94 <ke...@163.com> wrote:
>
> >
> >
> > > 在 2020年3月27日，20:25，Sheng Wu <wu...@apache.org> 写道：
> > >
> > > Hi Dev team
> > >
> > > There is a discussion happening on GitHub issue. I hope that could
> > continue
> > > on the mail list.
> > >
> > > Vr Vlaa wants to add a mechanism to disable plugin without physical
> > > deletion. I propose to keep using agent.config file and the names in
> the
> > > plugin.def files.
> > >
> >
> > It’s ok to use the key in .def files, but as a reminder, the keys are not
> > strict rules and is subject to change
> >
> > > I want to hear more from others from dev team.
> > >
> > > Sheng Wu
> > >
> > > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
> > >
> > >> ---------- Forwarded message ---------
> > >> From: 吴晟 Wu Sheng <no...@github.com>
> > >> Date: Fri, Mar 27, 2020 at 7:47 AM
> > >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
> > >> (#4578)
> > >> To: apache/skywalking <sk...@noreply.github.com>
> > >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
> > >> author@noreply.github.com>
> > >>
> > >>
> > >> I prefer you still use the agent.config to deactivate, by listing the
> > >> disable plugin names. You should notice all plugin.def includes names,
> > You
> > >> should use those names to disable agent plugins.
> > >>
> > >> WDYT?
> > >>
> > >> And, this discussion should happen in the mail list, could you forward
> > >> there?
> > >>
> > >> —
> > >> You are receiving this because you authored the thread.
> > >> Reply to this email directly, view it on GitHub
> > >> <
> > https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
> >,
> > >> or unsubscribe
> > >> <
> > >>
> >
> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
> > >>>
> > >> .
> > >>
> > > --
> > > Sheng Wu 吴晟
> > >
> > > Apache SkyWalking
> > > Apache Incubator
> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > > Zipkin
> > > Twitter, wusheng1108
> > >
> >
> >
> >
>
--
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by "kezhenxu94@163" <ke...@163.com>.
> On Mar 30, 2020, at 20:46, Viswa Ramamoorthy <vi...@gmail.com> wrote:
>
> Yes. I gave have seen it. But in a release plugin keys would stay the same. Right?
>
Not necessarily, the keys are absolutely possible to change when we support new versions of a framework, because, as you can see, the keys are mostly related to versions like activemq-5.x, avro-1.x, elasticsearch-6.x, etc.
> Ideally plugins could be given a ID that can be a separate enhancement in a new release.
>
> On Mon, Mar 30, 2020, 6:25 AM kezhenxu94 <ke...@163.com> wrote:
>
>
> > 在 2020年3月27日，20:25，Sheng Wu <wu...@apache.org> 写道：
> >
> > Hi Dev team
> >
> > There is a discussion happening on GitHub issue. I hope that could continue
> > on the mail list.
> >
> > Vr Vlaa wants to add a mechanism to disable plugin without physical
> > deletion. I propose to keep using agent.config file and the names in the
> > plugin.def files.
> >
>
> It’s ok to use the key in .def files, but as a reminder, the keys are not strict rules and is subject to change
>
> > I want to hear more from others from dev team.
> >
> > Sheng Wu
> >
> > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
> >
> >> ---------- Forwarded message ---------
> >> From: 吴晟 Wu Sheng <no...@github.com>
> >> Date: Fri, Mar 27, 2020 at 7:47 AM
> >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
> >> (#4578)
> >> To: apache/skywalking <sk...@noreply.github.com>
> >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
> >> author@noreply.github.com>
> >>
> >>
> >> I prefer you still use the agent.config to deactivate, by listing the
> >> disable plugin names. You should notice all plugin.def includes names, You
> >> should use those names to disable agent plugins.
> >>
> >> WDYT?
> >>
> >> And, this discussion should happen in the mail list, could you forward
> >> there?
> >>
> >> —
> >> You are receiving this because you authored the thread.
> >> Reply to this email directly, view it on GitHub
> >> <https://github.com/apache/skywalking/issues/4578#issuecomment-604957166>,
> >> or unsubscribe
> >> <
> >> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
> >>>
> >> .
> >>
> > --
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking
> > Apache Incubator
> > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > Zipkin
> > Twitter, wusheng1108
> >
>
>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Viswa Ramamoorthy <vi...@gmail.com>.
Yes. I gave have seen it. But in a release plugin keys would stay the same.
Right?
Ideally plugins could be given a ID that can be a separate enhancement in a
new release.
On Mon, Mar 30, 2020, 6:25 AM kezhenxu94 <ke...@163.com> wrote:
>
>
> > 在 2020年3月27日，20:25，Sheng Wu <wu...@apache.org> 写道：
> >
> > Hi Dev team
> >
> > There is a discussion happening on GitHub issue. I hope that could
> continue
> > on the mail list.
> >
> > Vr Vlaa wants to add a mechanism to disable plugin without physical
> > deletion. I propose to keep using agent.config file and the names in the
> > plugin.def files.
> >
>
> It’s ok to use the key in .def files, but as a reminder, the keys are not
> strict rules and is subject to change
>
> > I want to hear more from others from dev team.
> >
> > Sheng Wu
> >
> > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
> >
> >> ---------- Forwarded message ---------
> >> From: 吴晟 Wu Sheng <no...@github.com>
> >> Date: Fri, Mar 27, 2020 at 7:47 AM
> >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
> >> (#4578)
> >> To: apache/skywalking <sk...@noreply.github.com>
> >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
> >> author@noreply.github.com>
> >>
> >>
> >> I prefer you still use the agent.config to deactivate, by listing the
> >> disable plugin names. You should notice all plugin.def includes names,
> You
> >> should use those names to disable agent plugins.
> >>
> >> WDYT?
> >>
> >> And, this discussion should happen in the mail list, could you forward
> >> there?
> >>
> >> —
> >> You are receiving this because you authored the thread.
> >> Reply to this email directly, view it on GitHub
> >> <
> https://github.com/apache/skywalking/issues/4578#issuecomment-604957166>,
> >> or unsubscribe
> >> <
> >>
> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
> >>>
> >> .
> >>
> > --
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking
> > Apache Incubator
> > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > Zipkin
> > Twitter, wusheng1108
> >
>
>
>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by kezhenxu94 <ke...@163.com>.
> 在 2020年3月27日，20:25，Sheng Wu <wu...@apache.org> 写道：
>
> Hi Dev team
>
> There is a discussion happening on GitHub issue. I hope that could continue
> on the mail list.
>
> Vr Vlaa wants to add a mechanism to disable plugin without physical
> deletion. I propose to keep using agent.config file and the names in the
> plugin.def files.
>
It’s ok to use the key in .def files, but as a reminder, the keys are not strict rules and is subject to change
> I want to hear more from others from dev team.
>
> Sheng Wu
>
> Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
>
>> ---------- Forwarded message ---------
>> From: 吴晟 Wu Sheng <no...@github.com>
>> Date: Fri, Mar 27, 2020 at 7:47 AM
>> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
>> (#4578)
>> To: apache/skywalking <sk...@noreply.github.com>
>> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
>> author@noreply.github.com>
>>
>>
>> I prefer you still use the agent.config to deactivate, by listing the
>> disable plugin names. You should notice all plugin.def includes names, You
>> should use those names to disable agent plugins.
>>
>> WDYT?
>>
>> And, this discussion should happen in the mail list, could you forward
>> there?
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/skywalking/issues/4578#issuecomment-604957166>,
>> or unsubscribe
>> <
>> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
>>>
>> .
>>
> --
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Viswa Ramamoorthy <vi...@gmail.com>.
Typically a configuration like this could be both ways as this is a long
list of auto configured plugins.
On Mon, Mar 30, 2020, 5:38 AM Sheng Wu <wu...@gmail.com> wrote:
> Seems acceptable to me. Just curious are real both ways required?
> Normally, people use an image tag to represent the agent(with necessary
> plugins) for their different services normally.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Viswa Ramamoorthy <vi...@gmail.com> 于2020年3月30日周一 下午5:35写道：
>
>> yes
>>
>> On Sun, Mar 29, 2020 at 8:32 PM Sheng Wu <wu...@gmail.com>
>> wrote:
>>
>>> Hi
>>>
>>> What is the expected behavior of `enable_plugins`? If make the core only
>>> active the listed plugins?
>>>
>>> Sheng Wu 吴晟
>>> Twitter, wusheng1108
>>>
>>>
>>> Vr Vlaa <vi...@gmail.com> 于2020年3月29日周日 下午8:55写道：
>>>
>>>> I will send PR
>>>>
>>>> Assuming that we will introduce a new black list property called
>>>> 'disable_plugins' in agent.config to list comma separated keys to plugin
>>>> ids to be disabled.
>>>>
>>>> Below is an example.
>>>>
>>>> #the below will disable activemq-5.x-plugin & armeria-0.84.x-plugin
>>>> disable_plugins=activemq-5.x,armeria-063-084
>>>>
>>>> I am also thinking to introduce a white list property called
>>>> 'enable_plugins' in agent.config to list comma separated keys to plugin ids
>>>> to be enabled. NOTE that 'enable_plugins' property takes precedence over
>>>> 'disable_plugins' and when 'enable_plugins' is in agent.config
>>>> 'disable_plugins' property is ignored.
>>>>
>>>> #the below will enable ON:Y elasticsearch-6.x-plugin &
>>>> rabbitmq-5.x-plugin; NOTE that disable_plugins is ignored
>>>> when enable_plugins is in agent.config
>>>> enable_plugins=elasticsearch-6.x,rabbitmq-5.x
>>>>
>>>> Let me know what you think
>>>>
>>>>
>>>>
>>>> On Sat, Mar 28, 2020 at 11:18 PM Sheng Wu <wu...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi Vr Vlaa
>>>>>
>>>>> It seems NO objection from the team. you could work on this and look
>>>>> forward to your pull request.
>>>>>
>>>>> Sheng Wu 吴晟
>>>>> Twitter, wusheng1108
>>>>>
>>>>>
>>>>> han liu <mr...@gmail.com> 于2020年3月27日周五 下午9:44写道：
>>>>>
>>>>>> I think add the configuration item in `agent.conf` to close plugins is
>>>>>> looking good to me.
>>>>>>
>>>>>> In this way, both configuration file and environment variables can be
>>>>>> take
>>>>>> effect after restarted the application.
>>>>>>
>>>>>>
>>>>>> Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午9:23写道：
>>>>>>
>>>>>> > I am fine with listing plugin names in agent.config to disable
>>>>>> instead of
>>>>>> > feeding via skywalking-plugin.def in that format. As long as we
>>>>>> have a way
>>>>>> > to disable plugins via agent.config, it handles this requirement.
>>>>>> >
>>>>>> >
>>>>>> > On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <wu...@apache.org>
>>>>>> wrote:
>>>>>> >
>>>>>> > > Hi Dev team
>>>>>> > >
>>>>>> > > There is a discussion happening on GitHub issue. I hope that could
>>>>>> > > continue on the mail list.
>>>>>> > >
>>>>>> > > Vr Vlaa wants to add a mechanism to disable plugin without
>>>>>> physical
>>>>>> > > deletion. I propose to keep using agent.config file and the names
>>>>>> in the
>>>>>> > > plugin.def files.
>>>>>> > >
>>>>>> > > I want to hear more from others from dev team.
>>>>>> > >
>>>>>> > > Sheng Wu
>>>>>> > >
>>>>>> > > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
>>>>>> > >
>>>>>> > >> ---------- Forwarded message ---------
>>>>>> > >> From: 吴晟 Wu Sheng <no...@github.com>
>>>>>> > >> Date: Fri, Mar 27, 2020 at 7:47 AM
>>>>>> > >> Subject: Re: [apache/skywalking] Provide ability to turn off
>>>>>> plugins
>>>>>> > >> (#4578)
>>>>>> > >> To: apache/skywalking <sk...@noreply.github.com>
>>>>>> > >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
>>>>>> > >> author@noreply.github.com>
>>>>>> > >>
>>>>>> > >>
>>>>>> > >> I prefer you still use the agent.config to deactivate, by
>>>>>> listing the
>>>>>> > >> disable plugin names. You should notice all plugin.def includes
>>>>>> names,
>>>>>> > You
>>>>>> > >> should use those names to disable agent plugins.
>>>>>> > >>
>>>>>> > >> WDYT?
>>>>>> > >>
>>>>>> > >> And, this discussion should happen in the mail list, could you
>>>>>> forward
>>>>>> > >> there?
>>>>>> > >>
>>>>>> > >> —
>>>>>> > >> You are receiving this because you authored the thread.
>>>>>> > >> Reply to this email directly, view it on GitHub
>>>>>> > >> <
>>>>>> >
>>>>>> https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
>>>>>> > >> >,
>>>>>> > >> or unsubscribe
>>>>>> > >> <
>>>>>> > >>
>>>>>> >
>>>>>> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
>>>>>> > >> >
>>>>>> > >> .
>>>>>> > >>
>>>>>> > > --
>>>>>> > > Sheng Wu 吴晟
>>>>>> > >
>>>>>> > > Apache SkyWalking
>>>>>> > > Apache Incubator
>>>>>> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
>>>>>> > > Zipkin
>>>>>> > > Twitter, wusheng1108
>>>>>> > >
>>>>>> >
>>>>>>
>>>>>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Sheng Wu <wu...@gmail.com>.
Seems acceptable to me. Just curious are real both ways required?
Normally, people use an image tag to represent the agent(with necessary
plugins) for their different services normally.
Sheng Wu 吴晟
Twitter, wusheng1108
Viswa Ramamoorthy <vi...@gmail.com> 于2020年3月30日周一 下午5:35写道：
> yes
>
> On Sun, Mar 29, 2020 at 8:32 PM Sheng Wu <wu...@gmail.com>
> wrote:
>
>> Hi
>>
>> What is the expected behavior of `enable_plugins`? If make the core only
>> active the listed plugins?
>>
>> Sheng Wu 吴晟
>> Twitter, wusheng1108
>>
>>
>> Vr Vlaa <vi...@gmail.com> 于2020年3月29日周日 下午8:55写道：
>>
>>> I will send PR
>>>
>>> Assuming that we will introduce a new black list property called
>>> 'disable_plugins' in agent.config to list comma separated keys to plugin
>>> ids to be disabled.
>>>
>>> Below is an example.
>>>
>>> #the below will disable activemq-5.x-plugin & armeria-0.84.x-plugin
>>> disable_plugins=activemq-5.x,armeria-063-084
>>>
>>> I am also thinking to introduce a white list property called
>>> 'enable_plugins' in agent.config to list comma separated keys to plugin ids
>>> to be enabled. NOTE that 'enable_plugins' property takes precedence over
>>> 'disable_plugins' and when 'enable_plugins' is in agent.config
>>> 'disable_plugins' property is ignored.
>>>
>>> #the below will enable ON:Y elasticsearch-6.x-plugin &
>>> rabbitmq-5.x-plugin; NOTE that disable_plugins is ignored
>>> when enable_plugins is in agent.config
>>> enable_plugins=elasticsearch-6.x,rabbitmq-5.x
>>>
>>> Let me know what you think
>>>
>>>
>>>
>>> On Sat, Mar 28, 2020 at 11:18 PM Sheng Wu <wu...@gmail.com>
>>> wrote:
>>>
>>>> Hi Vr Vlaa
>>>>
>>>> It seems NO objection from the team. you could work on this and look
>>>> forward to your pull request.
>>>>
>>>> Sheng Wu 吴晟
>>>> Twitter, wusheng1108
>>>>
>>>>
>>>> han liu <mr...@gmail.com> 于2020年3月27日周五 下午9:44写道：
>>>>
>>>>> I think add the configuration item in `agent.conf` to close plugins is
>>>>> looking good to me.
>>>>>
>>>>> In this way, both configuration file and environment variables can be
>>>>> take
>>>>> effect after restarted the application.
>>>>>
>>>>>
>>>>> Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午9:23写道：
>>>>>
>>>>> > I am fine with listing plugin names in agent.config to disable
>>>>> instead of
>>>>> > feeding via skywalking-plugin.def in that format. As long as we have
>>>>> a way
>>>>> > to disable plugins via agent.config, it handles this requirement.
>>>>> >
>>>>> >
>>>>> > On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <wu...@apache.org> wrote:
>>>>> >
>>>>> > > Hi Dev team
>>>>> > >
>>>>> > > There is a discussion happening on GitHub issue. I hope that could
>>>>> > > continue on the mail list.
>>>>> > >
>>>>> > > Vr Vlaa wants to add a mechanism to disable plugin without
>>>>> physical
>>>>> > > deletion. I propose to keep using agent.config file and the names
>>>>> in the
>>>>> > > plugin.def files.
>>>>> > >
>>>>> > > I want to hear more from others from dev team.
>>>>> > >
>>>>> > > Sheng Wu
>>>>> > >
>>>>> > > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
>>>>> > >
>>>>> > >> ---------- Forwarded message ---------
>>>>> > >> From: 吴晟 Wu Sheng <no...@github.com>
>>>>> > >> Date: Fri, Mar 27, 2020 at 7:47 AM
>>>>> > >> Subject: Re: [apache/skywalking] Provide ability to turn off
>>>>> plugins
>>>>> > >> (#4578)
>>>>> > >> To: apache/skywalking <sk...@noreply.github.com>
>>>>> > >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
>>>>> > >> author@noreply.github.com>
>>>>> > >>
>>>>> > >>
>>>>> > >> I prefer you still use the agent.config to deactivate, by listing
>>>>> the
>>>>> > >> disable plugin names. You should notice all plugin.def includes
>>>>> names,
>>>>> > You
>>>>> > >> should use those names to disable agent plugins.
>>>>> > >>
>>>>> > >> WDYT?
>>>>> > >>
>>>>> > >> And, this discussion should happen in the mail list, could you
>>>>> forward
>>>>> > >> there?
>>>>> > >>
>>>>> > >> —
>>>>> > >> You are receiving this because you authored the thread.
>>>>> > >> Reply to this email directly, view it on GitHub
>>>>> > >> <
>>>>> >
>>>>> https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
>>>>> > >> >,
>>>>> > >> or unsubscribe
>>>>> > >> <
>>>>> > >>
>>>>> >
>>>>> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
>>>>> > >> >
>>>>> > >> .
>>>>> > >>
>>>>> > > --
>>>>> > > Sheng Wu 吴晟
>>>>> > >
>>>>> > > Apache SkyWalking
>>>>> > > Apache Incubator
>>>>> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
>>>>> > > Zipkin
>>>>> > > Twitter, wusheng1108
>>>>> > >
>>>>> >
>>>>>
>>>>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Sheng Wu <wu...@gmail.com>.
Hi
What is the expected behavior of `enable_plugins`? If make the core only
active the listed plugins?
Sheng Wu 吴晟
Twitter, wusheng1108
Vr Vlaa <vi...@gmail.com> 于2020年3月29日周日 下午8:55写道：
> I will send PR
>
> Assuming that we will introduce a new black list property called
> 'disable_plugins' in agent.config to list comma separated keys to plugin
> ids to be disabled.
>
> Below is an example.
>
> #the below will disable activemq-5.x-plugin & armeria-0.84.x-plugin
> disable_plugins=activemq-5.x,armeria-063-084
>
> I am also thinking to introduce a white list property called
> 'enable_plugins' in agent.config to list comma separated keys to plugin ids
> to be enabled. NOTE that 'enable_plugins' property takes precedence over
> 'disable_plugins' and when 'enable_plugins' is in agent.config
> 'disable_plugins' property is ignored.
>
> #the below will enable ON:Y elasticsearch-6.x-plugin &
> rabbitmq-5.x-plugin; NOTE that disable_plugins is ignored
> when enable_plugins is in agent.config
> enable_plugins=elasticsearch-6.x,rabbitmq-5.x
>
> Let me know what you think
>
>
>
> On Sat, Mar 28, 2020 at 11:18 PM Sheng Wu <wu...@gmail.com>
> wrote:
>
>> Hi Vr Vlaa
>>
>> It seems NO objection from the team. you could work on this and look
>> forward to your pull request.
>>
>> Sheng Wu 吴晟
>> Twitter, wusheng1108
>>
>>
>> han liu <mr...@gmail.com> 于2020年3月27日周五 下午9:44写道：
>>
>>> I think add the configuration item in `agent.conf` to close plugins is
>>> looking good to me.
>>>
>>> In this way, both configuration file and environment variables can be
>>> take
>>> effect after restarted the application.
>>>
>>>
>>> Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午9:23写道：
>>>
>>> > I am fine with listing plugin names in agent.config to disable instead
>>> of
>>> > feeding via skywalking-plugin.def in that format. As long as we have a
>>> way
>>> > to disable plugins via agent.config, it handles this requirement.
>>> >
>>> >
>>> > On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <wu...@apache.org> wrote:
>>> >
>>> > > Hi Dev team
>>> > >
>>> > > There is a discussion happening on GitHub issue. I hope that could
>>> > > continue on the mail list.
>>> > >
>>> > > Vr Vlaa wants to add a mechanism to disable plugin without physical
>>> > > deletion. I propose to keep using agent.config file and the names in
>>> the
>>> > > plugin.def files.
>>> > >
>>> > > I want to hear more from others from dev team.
>>> > >
>>> > > Sheng Wu
>>> > >
>>> > > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
>>> > >
>>> > >> ---------- Forwarded message ---------
>>> > >> From: 吴晟 Wu Sheng <no...@github.com>
>>> > >> Date: Fri, Mar 27, 2020 at 7:47 AM
>>> > >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
>>> > >> (#4578)
>>> > >> To: apache/skywalking <sk...@noreply.github.com>
>>> > >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
>>> > >> author@noreply.github.com>
>>> > >>
>>> > >>
>>> > >> I prefer you still use the agent.config to deactivate, by listing
>>> the
>>> > >> disable plugin names. You should notice all plugin.def includes
>>> names,
>>> > You
>>> > >> should use those names to disable agent plugins.
>>> > >>
>>> > >> WDYT?
>>> > >>
>>> > >> And, this discussion should happen in the mail list, could you
>>> forward
>>> > >> there?
>>> > >>
>>> > >> —
>>> > >> You are receiving this because you authored the thread.
>>> > >> Reply to this email directly, view it on GitHub
>>> > >> <
>>> >
>>> https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
>>> > >> >,
>>> > >> or unsubscribe
>>> > >> <
>>> > >>
>>> >
>>> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
>>> > >> >
>>> > >> .
>>> > >>
>>> > > --
>>> > > Sheng Wu 吴晟
>>> > >
>>> > > Apache SkyWalking
>>> > > Apache Incubator
>>> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
>>> > > Zipkin
>>> > > Twitter, wusheng1108
>>> > >
>>> >
>>>
>>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Vr Vlaa <vi...@gmail.com>.
I will send PR
Assuming that we will introduce a new black list property called
'disable_plugins' in agent.config to list comma separated keys to plugin
ids to be disabled.
Below is an example.
#the below will disable activemq-5.x-plugin & armeria-0.84.x-plugin
disable_plugins=activemq-5.x,armeria-063-084
I am also thinking to introduce a white list property called
'enable_plugins' in agent.config to list comma separated keys to plugin ids
to be enabled. NOTE that 'enable_plugins' property takes precedence over
'disable_plugins' and when 'enable_plugins' is in agent.config
'disable_plugins' property is ignored.
#the below will enable ON:Y elasticsearch-6.x-plugin & rabbitmq-5.x-plugin;
NOTE that disable_plugins is ignored when enable_plugins is in agent.config
enable_plugins=elasticsearch-6.x,rabbitmq-5.x
Let me know what you think
On Sat, Mar 28, 2020 at 11:18 PM Sheng Wu <wu...@gmail.com> wrote:
> Hi Vr Vlaa
>
> It seems NO objection from the team. you could work on this and look
> forward to your pull request.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> han liu <mr...@gmail.com> 于2020年3月27日周五 下午9:44写道：
>
>> I think add the configuration item in `agent.conf` to close plugins is
>> looking good to me.
>>
>> In this way, both configuration file and environment variables can be take
>> effect after restarted the application.
>>
>>
>> Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午9:23写道：
>>
>> > I am fine with listing plugin names in agent.config to disable instead
>> of
>> > feeding via skywalking-plugin.def in that format. As long as we have a
>> way
>> > to disable plugins via agent.config, it handles this requirement.
>> >
>> >
>> > On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <wu...@apache.org> wrote:
>> >
>> > > Hi Dev team
>> > >
>> > > There is a discussion happening on GitHub issue. I hope that could
>> > > continue on the mail list.
>> > >
>> > > Vr Vlaa wants to add a mechanism to disable plugin without physical
>> > > deletion. I propose to keep using agent.config file and the names in
>> the
>> > > plugin.def files.
>> > >
>> > > I want to hear more from others from dev team.
>> > >
>> > > Sheng Wu
>> > >
>> > > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
>> > >
>> > >> ---------- Forwarded message ---------
>> > >> From: 吴晟 Wu Sheng <no...@github.com>
>> > >> Date: Fri, Mar 27, 2020 at 7:47 AM
>> > >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
>> > >> (#4578)
>> > >> To: apache/skywalking <sk...@noreply.github.com>
>> > >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
>> > >> author@noreply.github.com>
>> > >>
>> > >>
>> > >> I prefer you still use the agent.config to deactivate, by listing the
>> > >> disable plugin names. You should notice all plugin.def includes
>> names,
>> > You
>> > >> should use those names to disable agent plugins.
>> > >>
>> > >> WDYT?
>> > >>
>> > >> And, this discussion should happen in the mail list, could you
>> forward
>> > >> there?
>> > >>
>> > >> —
>> > >> You are receiving this because you authored the thread.
>> > >> Reply to this email directly, view it on GitHub
>> > >> <
>> > https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
>> > >> >,
>> > >> or unsubscribe
>> > >> <
>> > >>
>> >
>> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
>> > >> >
>> > >> .
>> > >>
>> > > --
>> > > Sheng Wu 吴晟
>> > >
>> > > Apache SkyWalking
>> > > Apache Incubator
>> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
>> > > Zipkin
>> > > Twitter, wusheng1108
>> > >
>> >
>>
>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Sheng Wu <wu...@gmail.com>.
Hi Vr Vlaa
It seems NO objection from the team. you could work on this and look
forward to your pull request.
Sheng Wu 吴晟
Twitter, wusheng1108
han liu <mr...@gmail.com> 于2020年3月27日周五 下午9:44写道：
> I think add the configuration item in `agent.conf` to close plugins is
> looking good to me.
>
> In this way, both configuration file and environment variables can be take
> effect after restarted the application.
>
>
> Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午9:23写道：
>
> > I am fine with listing plugin names in agent.config to disable instead of
> > feeding via skywalking-plugin.def in that format. As long as we have a
> way
> > to disable plugins via agent.config, it handles this requirement.
> >
> >
> > On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <wu...@apache.org> wrote:
> >
> > > Hi Dev team
> > >
> > > There is a discussion happening on GitHub issue. I hope that could
> > > continue on the mail list.
> > >
> > > Vr Vlaa wants to add a mechanism to disable plugin without physical
> > > deletion. I propose to keep using agent.config file and the names in
> the
> > > plugin.def files.
> > >
> > > I want to hear more from others from dev team.
> > >
> > > Sheng Wu
> > >
> > > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
> > >
> > >> ---------- Forwarded message ---------
> > >> From: 吴晟 Wu Sheng <no...@github.com>
> > >> Date: Fri, Mar 27, 2020 at 7:47 AM
> > >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
> > >> (#4578)
> > >> To: apache/skywalking <sk...@noreply.github.com>
> > >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
> > >> author@noreply.github.com>
> > >>
> > >>
> > >> I prefer you still use the agent.config to deactivate, by listing the
> > >> disable plugin names. You should notice all plugin.def includes names,
> > You
> > >> should use those names to disable agent plugins.
> > >>
> > >> WDYT?
> > >>
> > >> And, this discussion should happen in the mail list, could you forward
> > >> there?
> > >>
> > >> —
> > >> You are receiving this because you authored the thread.
> > >> Reply to this email directly, view it on GitHub
> > >> <
> > https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
> > >> >,
> > >> or unsubscribe
> > >> <
> > >>
> >
> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
> > >> >
> > >> .
> > >>
> > > --
> > > Sheng Wu 吴晟
> > >
> > > Apache SkyWalking
> > > Apache Incubator
> > > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > > Zipkin
> > > Twitter, wusheng1108
> > >
> >
>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by han liu <mr...@gmail.com>.
I think add the configuration item in `agent.conf` to close plugins is
looking good to me.
In this way, both configuration file and environment variables can be take
effect after restarted the application.
Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午9:23写道：
> I am fine with listing plugin names in agent.config to disable instead of
> feeding via skywalking-plugin.def in that format. As long as we have a way
> to disable plugins via agent.config, it handles this requirement.
>
>
> On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <wu...@apache.org> wrote:
>
> > Hi Dev team
> >
> > There is a discussion happening on GitHub issue. I hope that could
> > continue on the mail list.
> >
> > Vr Vlaa wants to add a mechanism to disable plugin without physical
> > deletion. I propose to keep using agent.config file and the names in the
> > plugin.def files.
> >
> > I want to hear more from others from dev team.
> >
> > Sheng Wu
> >
> > Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
> >
> >> ---------- Forwarded message ---------
> >> From: 吴晟 Wu Sheng <no...@github.com>
> >> Date: Fri, Mar 27, 2020 at 7:47 AM
> >> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
> >> (#4578)
> >> To: apache/skywalking <sk...@noreply.github.com>
> >> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
> >> author@noreply.github.com>
> >>
> >>
> >> I prefer you still use the agent.config to deactivate, by listing the
> >> disable plugin names. You should notice all plugin.def includes names,
> You
> >> should use those names to disable agent plugins.
> >>
> >> WDYT?
> >>
> >> And, this discussion should happen in the mail list, could you forward
> >> there?
> >>
> >> —
> >> You are receiving this because you authored the thread.
> >> Reply to this email directly, view it on GitHub
> >> <
> https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
> >> >,
> >> or unsubscribe
> >> <
> >>
> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
> >> >
> >> .
> >>
> > --
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking
> > Apache Incubator
> > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > Zipkin
> > Twitter, wusheng1108
> >
>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Vr Vlaa <vi...@gmail.com>.
I am fine with listing plugin names in agent.config to disable instead of
feeding via skywalking-plugin.def in that format. As long as we have a way
to disable plugins via agent.config, it handles this requirement.
On Fri, Mar 27, 2020 at 8:24 AM Sheng Wu <wu...@apache.org> wrote:
> Hi Dev team
>
> There is a discussion happening on GitHub issue. I hope that could
> continue on the mail list.
>
> Vr Vlaa wants to add a mechanism to disable plugin without physical
> deletion. I propose to keep using agent.config file and the names in the
> plugin.def files.
>
> I want to hear more from others from dev team.
>
> Sheng Wu
>
> Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
>
>> ---------- Forwarded message ---------
>> From: 吴晟 Wu Sheng <no...@github.com>
>> Date: Fri, Mar 27, 2020 at 7:47 AM
>> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
>> (#4578)
>> To: apache/skywalking <sk...@noreply.github.com>
>> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
>> author@noreply.github.com>
>>
>>
>> I prefer you still use the agent.config to deactivate, by listing the
>> disable plugin names. You should notice all plugin.def includes names, You
>> should use those names to disable agent plugins.
>>
>> WDYT?
>>
>> And, this discussion should happen in the mail list, could you forward
>> there?
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/skywalking/issues/4578#issuecomment-604957166
>> >,
>> or unsubscribe
>> <
>> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
>> >
>> .
>>
> --
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
Re: [apache/skywalking] Provide ability to turn off plugins (#4578)
Posted by Sheng Wu <wu...@apache.org>.
Hi Dev team
There is a discussion happening on GitHub issue. I hope that could continue
on the mail list.
Vr Vlaa wants to add a mechanism to disable plugin without physical
deletion. I propose to keep using agent.config file and the names in the
plugin.def files.
I want to hear more from others from dev team.
Sheng Wu
Vr Vlaa <vi...@gmail.com>于2020年3月27日 周五下午8:19写道：
> ---------- Forwarded message ---------
> From: 吴晟 Wu Sheng <no...@github.com>
> Date: Fri, Mar 27, 2020 at 7:47 AM
> Subject: Re: [apache/skywalking] Provide ability to turn off plugins
> (#4578)
> To: apache/skywalking <sk...@noreply.github.com>
> Cc: viswaramamoorthy <vi...@gmail.com>, Author <
> author@noreply.github.com>
>
>
> I prefer you still use the agent.config to deactivate, by listing the
> disable plugin names. You should notice all plugin.def includes names, You
> should use those names to disable agent plugins.
>
> WDYT?
>
> And, this discussion should happen in the mail list, could you forward
> there?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/skywalking/issues/4578#issuecomment-604957166>,
> or unsubscribe
> <
> https://github.com/notifications/unsubscribe-auth/AF5E7VK5NFVIIF7M4UU3D2DRJSG4BANCNFSM4LUOVKJA
> >
> .
>
--
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108