You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/03/17 07:59:25 UTC
[GitHub] codecov-io commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID
codecov-io commented on issue #310: SCB-411 SC can not check the reduplicate endpoints when register with ID
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/310#issuecomment-373902301
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=h1) Report
> Merging [#310](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f8b3e7b95ef63709cfb933a3688a4714271ec518?src=pr&el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `56.91%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 70.33% 69.61% -0.72%
==========================================
Files 17 17
Lines 3452 3443 -9
==========================================
- Hits 2428 2397 -31
- Misses 853 874 +21
- Partials 171 172 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `47.16% <41.66%> (-1.93%)` | :arrow_down: |
| [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `67.28% <58.55%> (-3.84%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=footer). Last update [f8b3e7b...89b62fd](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/310?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services