You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/13 03:15:45 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #9194: fix memory leak

sijie commented on a change in pull request #9194:
URL: https://github.com/apache/pulsar/pull/9194#discussion_r556236691



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java
##########
@@ -99,6 +100,12 @@ public void onManagedLedgerLastLedgerInitialize(String name, LedgerHandle lh) {
             }
         } catch (org.apache.bookkeeper.client.api.BKException | InterruptedException e) {
             log.error("[{}] Read last entry error.", name, e);
+        } finally {
+            if (ledgerEntries != null) {

Review comment:
       LedgerEntries has a `close()` interface.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org