[GitHub] [kafka] cadonna commented on a change in pull request #10944: MINOR: Loose verification of startup in EOS system tests

[GitBox <gi...@apache.org>]

cadonna commented on a change in pull request #10944:
URL: https://github.com/apache/kafka/pull/10944#discussion_r662160463



##########
File path: tests/kafkatest/tests/streams/streams_eos_test.py
##########
@@ -166,7 +166,6 @@ def abort_streams(self, keep_alive_processor1, keep_alive_processor2, processor_
 
     def wait_for_startup(self, monitor, processor):
         self.wait_for(monitor, processor, "StateChange: REBALANCING -> RUNNING")
-        self.wait_for(monitor, processor, "processed [0-9]* records from topic")

Review comment:
       According to the logs the test uses even 2 standby replicas (`num.standby.replicas = 2`). The git history says it was configured that way long time ago on June 8, 2017 by a guy named @mjsax.  🙂  
   
   And even if it wouldn't, there is still the possibility that a warm-up standby task is assigned to the client, before the actual active task is moved to it. Note `with followup probing rebalance` in the logs I posted. We could wait for settlement of the assignment, but that would extend the runtime of the test. I get your point about ensuring to not move to the next step too quickly, though. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org