You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by rd...@apache.org on 2021/11/09 22:46:55 UTC

[pulsar] branch master updated: Fix flaky test: PersistentTopicsTest::testPeekWithSubscriptionNameNotExist (#12703)

This is an automated email from the ASF dual-hosted git repository.

rdhabalia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new cc68f56  Fix flaky test: PersistentTopicsTest::testPeekWithSubscriptionNameNotExist (#12703)
cc68f56 is described below

commit cc68f56c9c32ef4b1ea8595c688cd684eb0253f6
Author: Rajan Dhabalia <rd...@apache.org>
AuthorDate: Tue Nov 9 14:44:48 2021 -0800

    Fix flaky test: PersistentTopicsTest::testPeekWithSubscriptionNameNotExist (#12703)
---
 .../org/apache/pulsar/broker/admin/PersistentTopicsTest.java  | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
index 0333a0b..2cb2d57 100644
--- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
+++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
@@ -77,6 +77,7 @@ import org.apache.pulsar.common.partition.PartitionedTopicMetadata;
 import org.apache.pulsar.common.policies.data.AuthAction;
 import org.apache.pulsar.common.policies.data.ClusterData;
 import org.apache.pulsar.common.policies.data.Policies;
+import org.apache.pulsar.common.policies.data.RetentionPolicies;
 import org.apache.pulsar.common.policies.data.TenantInfoImpl;
 import org.apache.pulsar.common.policies.data.TopicStats;
 import org.apache.zookeeper.KeeperException;
@@ -668,18 +669,20 @@ public class PersistentTopicsTest extends MockedPulsarServiceBaseTest {
     @Test
     public void testPeekWithSubscriptionNameNotExist() throws Exception {
         final String topicName = "testTopic";
-        final String topic = TopicName.get(
+        final TopicName topic = TopicName.get(
                 TopicDomain.persistent.value(),
                 testTenant,
                 testNamespace,
-                topicName).toString();
+                topicName);
         final String subscriptionName = "sub";
 
-        ((TopicsImpl) admin.topics()).createPartitionedTopicAsync(topic, 3, true).get();
+        RetentionPolicies retention = new RetentionPolicies(10,10);
+        admin.namespaces().setRetention(topic.getNamespace(), retention);
+        ((TopicsImpl) admin.topics()).createPartitionedTopicAsync(topic.toString(), 3, true).get();
 
         final String partitionedTopic = topic + "-partition-0";
 
-        Producer<String> producer = pulsarClient.newProducer(Schema.STRING).topic(topic).create();
+        Producer<String> producer = pulsarClient.newProducer(Schema.STRING).topic(topic.toString()).create();
         for (int i = 0; i < 100; ++i) {
             producer.send("test" + i);
         }