[GitHub] [cassandra-accord] belliottsmith commented on a diff in pull request #38: CASSANDRA-18364: CEP-15: (C*) Accord message processing should avoid being passed on to a Stage and run directly in the messageing handler

["belliottsmith (via GitHub)" <gi...@apache.org>]

belliottsmith commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1152974290


##########
accord-core/src/main/java/accord/coordinate/CheckShards.java:
##########
@@ -61,7 +61,8 @@ private static Topologies topologyFor(Node node, TxnId txnId, Unseekables<?, ?>
     protected void contact(Id id)
     {
         Unseekables<?, ?> unseekables = contact.slice(topologies().computeRangesForNode(id));
-        node.send(id, new CheckStatus(txnId, unseekables, txnId.epoch(), untilRemoteEpoch, includeInfo), this);
+        node.send(id, new CheckStatus(txnId, unseekables, txnId.epoch(), untilRemoteEpoch, includeInfo),
+                  node.commandStores().from(unseekables), this);

Review Comment:
   Shouldn't we already know the `CommandStore` - it should be the one we're executing on ourselves?
   
   Perhaps we should introduce a static method for discovering the `CommandStore` we're executing on currently, and store it in a `ThreadLocal` (or `FastThreadLocal`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org