You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/20 18:54:43 UTC
[GitHub] [couchdb] rnewson commented on a change in pull request #2687: Jwt
enhancements
rnewson commented on a change in pull request #2687: Jwt enhancements
URL: https://github.com/apache/couchdb/pull/2687#discussion_r395832562
##########
File path: rel/overlay/etc/default.ini
##########
@@ -141,12 +141,16 @@ max_db_number_for_dbs_info_req = 100
; admin_only_all_dbs = true
;[jwt_auth]
-; Symmetric secret to be used when checking JWT token signatures
-; secret =
; List of claims to validate
; required_claims = exp
; List of algorithms to accept during checks
; allowed_algorithms = HS256
+;
+; [jwt_keys]
+; Default secret to be used when checking JWT token signatures
Review comment:
I'll expand the text. I also think the symmetric key will need to be base64 encoded in the config, so we can allow binary values. So far we've assumed text is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services