You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/25 18:00:25 UTC
[GitHub] [netbeans] dyorgio opened a new pull request #3866: [NETBEANS-6329] Tools > Show In Finder don't works on JDK 17
dyorgio opened a new pull request #3866:
URL: https://github.com/apache/netbeans/pull/3866
Include exports to can execute macOs 'Show In Finder' action in jdk17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #3866: [NETBEANS-6329] Tools > Show In Finder don't works on JDK 17
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #3866:
URL: https://github.com/apache/netbeans/pull/3866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dyorgio commented on pull request #3866: [NETBEANS-6329] Tools > Show In Finder don't works on JDK 17
Posted by GitBox <gi...@apache.org>.
dyorgio commented on pull request #3866:
URL: https://github.com/apache/netbeans/pull/3866#issuecomment-1079427054
Hi @matthiasblaesing, yes it does, but only if you call getParentFile:
```java
// Current Implementation
final Class<?> fmClz = Class.forName("com.apple.eio.FileManager"); //NOI18N
final Method m = fmClz.getDeclaredMethod("revealInFinder", File.class); //NOI18N
m.invoke(null, new File("/PATH/FILE.EXT"));
// Suggested Implementation
Desktop.getDesktop().browse(new File("/PATH/FILE.EXT").getParentFile().toURI());
```
But I only tested on macOS 12.3 (latest), with 1.8 and 17 java versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3866: [NETBEANS-6329] Tools > Show In Finder don't works on JDK 17
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3866:
URL: https://github.com/apache/netbeans/pull/3866#issuecomment-1079748940
Unittests are green - @dyorgio I suggest to merge this as is. It is low risk and fixes a problem, so it is an improvement in anycase.
Independent of that it would be good to get rid of the add-exports if possible, so if you would follow up with the suggested implementation.
Please indicate if you agree that I merge now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dyorgio edited a comment on pull request #3866: [NETBEANS-6329] Tools > Show In Finder don't works on JDK 17
Posted by GitBox <gi...@apache.org>.
dyorgio edited a comment on pull request #3866:
URL: https://github.com/apache/netbeans/pull/3866#issuecomment-1079775926
Yes I also prefer the original solution.
We cannot guarantee that another versions of macOS will work with Desktop.browser, I suspect that it is the reason to use platform specific implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dyorgio commented on pull request #3866: [NETBEANS-6329] Tools > Show In Finder don't works on JDK 17
Posted by GitBox <gi...@apache.org>.
dyorgio commented on pull request #3866:
URL: https://github.com/apache/netbeans/pull/3866#issuecomment-1079775926
Yes I also prefer the original solution.
We can guarantee that another versions of macOS will work with Desktop.browser, I suspect that it is the reason to use platform specific implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3866: [NETBEANS-6329] Tools > Show In Finder don't works on JDK 17
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3866:
URL: https://github.com/apache/netbeans/pull/3866#issuecomment-1079377651
Looks sane to me. The affected class is `com.apple.eio.FileManager` called from `org.netbeans.modules.applemenu.ShowInFinder`. It would be nice though to investigate if using `java.awt.Desktop` would be an option (the `browse` method in that class does the right thing (at least looks like it) on linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists