You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/17 04:11:01 UTC
[GitHub] [incubator-superset] villebro commented on issue #7525: Add
relative start param for time filters
villebro commented on issue #7525: Add relative start param for time filters
URL: https://github.com/apache/incubator-superset/pull/7525#issuecomment-493312547
This got me thinking more broadly about time filters. I think default behaviour for the presets (Last x days/weeks/etc) should apply the time grain to the where clause. For example, when applying a "Last Year" with quarterly grains, the first quarter will almost always have an incomplete set of rows, as the where clause will start somewhere between the start and and of the first quarter. It would be more logical to omit the first quarter entirely to make sure that all quarters are true full quarters. Applying the time grain to the time filter would rake care of this automatically. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org