You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by miyajan <gi...@git.apache.org> on 2014/09/24 10:32:39 UTC

[GitHub] maven-surefire pull request: SUREFIRE-1098 Fix runOrder=balanced i...

GitHub user miyajan opened a pull request:

    https://github.com/apache/maven-surefire/pull/48

    SUREFIRE-1098 Fix runOrder=balanced is not working

    http://jira.codehaus.org/browse/SUREFIRE-1098
    
    The first "getConfigChecksum" in "executeProvider" is calculated with empty properties.
    The next "getConfigChecksum" in "createForkStarter" or "createInprocessStarter" is calculated with properties having parameters.
    Since the properties are setup in "createStartupConfiguration" called between first and second "getConfigChecksum".
    For this reason, runOrder=balanced is not working.
    
    It seems that the "properties" is not necessary for calculating checksum.
    The parameters are added directly.
    
    I'm sorry for not writing tests.
    It is too difficult for me..
    Please help if possible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/miyajan/maven-surefire SUREFIRE-1098-runorder-balanced-is-not-working

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit bbcd3fd17a118daa0ddb000891070c8a23b68ce3
Author: jumpei-miyata <ju...@cybozu.co.jp>
Date:   2014-09-24T08:15:50Z

    [SUREFIRE-1098] runOrder=balanced is not working
    Submitted by: jumpei-miyata
    
    o Delete properties from calculating checksum

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[GitHub] maven-surefire pull request: [SUREFIRE-1098] Fix runOrder=balanced...

Posted by miyajan <gi...@git.apache.org>.

Github user miyajan closed the pull request at:

    https://github.com/apache/maven-surefire/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org