You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/08/29 14:55:42 UTC

[GitHub] activemq-artemis pull request #2278: ARTEMIS-2052 Fixing initial credit nego...

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2278

    ARTEMIS-2052 Fixing initial credit negotiation

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-2052

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2278
    
----

----


---

[GitHub] activemq-artemis issue #2278: ARTEMIS-2052 Fixing initial credit negotiation

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2278
  
    @cshannon your last negotiation commit broke the CI. this should fix it. Can you look at it?


---

[GitHub] activemq-artemis issue #2278: ARTEMIS-2052 Fixing initial credit negotiation

Posted by cshannon <gi...@git.apache.org>.

Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2278
  
    It looks like one of tests I added in ConsumerWindowSizeTest broker....testConsumerWindowSizeAddressSettingsDifferentAddressAndQueueName


---

[GitHub] activemq-artemis issue #2278: ARTEMIS-2052 Fixing initial credit negotiation

Posted by cshannon <gi...@git.apache.org>.

Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2278
  
    The issue is here: https://github.com/apache/activemq-artemis/blob/106e71bdf4f1cf7ddf0dfc37ce6bab76d5c00dad/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java#L1457
    
    That line should now change to: assertTrue(Wait.waitFor(() -> cons.getAvailableCredits().get() == consumer.getClientWindowSize() * 2, 5000, 500));
    
    And that will fix it


---

[GitHub] activemq-artemis pull request #2278: ARTEMIS-2052 Fixing initial credit nego...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2278


---

[GitHub] activemq-artemis issue #2278: ARTEMIS-2052 Fixing initial credit negotiation

Posted by cshannon <gi...@git.apache.org>.

Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2278
  
    @clebertsuconic - besides the test fix it looks good to me, thanks for fixing it


---