You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-cvs@httpd.apache.org by jo...@apache.org on 2010/11/15 20:00:28 UTC
svn commit: r1035412 - /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Author: joes
Date: Mon Nov 15 19:00:28 2010
New Revision: 1035412
URL: http://svn.apache.org/viewvc?rev=1035412&view=rev
Log:
fix httponly test
Modified:
httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Modified: httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
URL: http://svn.apache.org/viewvc/httpd/apreq/trunk/glue/perl/t/apreq/cookie.t?rev=1035412&r1=1035411&r2=1035412&view=diff
==============================================================================
--- httpd/apreq/trunk/glue/perl/t/apreq/cookie.t (original)
+++ httpd/apreq/trunk/glue/perl/t/apreq/cookie.t Mon Nov 15 19:00:28 2010
@@ -172,11 +172,11 @@ my $location = Apache::TestRequest::modu
my $test = 'httponly';
my $key = 'apache';
my $value = 'ok';
- my $cookie = "$key=$value; HttpOnly";
+ my $cookie = "foo=$test; path=/quux; domain=example.com; HttpOnly";
my ($header) =
GET_HEAD("$location?test=$test&key=$key") =~ /^#Set-Cookie:\s+(.+)/m;
- ok t_cmp($header, $cookie_in, $test);
+ ok t_cmp($header, $cookie, $test);
}
Re: svn commit: r1035412 - /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Posted by Joe Schaefer <jo...@yahoo.com>.
No rush. Philip is out of town for the next 2 weeks and
I'm pretty sure the 3 votes you'll need are between you,
me, and him.
----- Original Message ----
> From: Issac Goldstand <ma...@beamartyr.net>
> To: apreq-dev@httpd.apache.org
> Sent: Thu, November 25, 2010 7:15:17 AM
> Subject: Re: svn commit: r1035412 -
>/httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
>
> Yeah, I was surprised with a massive lack of tuits last weekend, but
> will start soon. Release is on, though.
>
> Issac
>
> On 25/11/2010 13:59, Joe Schaefer wrote:
> > AFAICT we're just waiting for Issac to start the RM process.
> >
> >
> >
> > ----- Original Message ----
> >> From: Clinton Gormley <cl...@traveljury.com>
> >> To: Joe Schaefer <jo...@yahoo.com>
> >> Cc: apreq-dev <ap...@httpd.apache.org>
> >> Sent: Thu, November 25, 2010 6:41:56 AM
> >> Subject: Re: svn commit: r1035412 -
> >> /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
> >>
> >> On Mon, 2010-11-15 at 11:09 -0800, Joe Schaefer wrote:
> >>> Didn't work for me ;-(.
> >> I've just tested the latest libapreq (commit 1036061) from trunk against
> >> perl 5.12.2 with apache 2.2.17 and mod_perl (commit 1029211) and
> >> libapreq is passing all tests.
> >>
> >> Also, I've figured out what that closure error in Registry was - I was
> >> running my build script as root, then to run the test suite, was doing:
> >>
> >> chmod -R a+rwX ./
> >> sudo -u nobody make test
> >>
> >> which meant that the Perl I'd used to build mod_perl was different from
> >> the Perl I was using to test it.
> >>
> >>
> >> Does this get us any closer to new releases?
> >>
> >> thanks
> >>
> >> Clint
> >>
> >>
> >>
> >>
> >
> >
>
>
Re: svn commit: r1035412 - /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Posted by Issac Goldstand <ma...@beamartyr.net>.
Yeah, I was surprised with a massive lack of tuits last weekend, but
will start soon. Release is on, though.
Issac
On 25/11/2010 13:59, Joe Schaefer wrote:
> AFAICT we're just waiting for Issac to start the RM process.
>
>
>
> ----- Original Message ----
>> From: Clinton Gormley <cl...@traveljury.com>
>> To: Joe Schaefer <jo...@yahoo.com>
>> Cc: apreq-dev <ap...@httpd.apache.org>
>> Sent: Thu, November 25, 2010 6:41:56 AM
>> Subject: Re: svn commit: r1035412 -
>> /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
>>
>> On Mon, 2010-11-15 at 11:09 -0800, Joe Schaefer wrote:
>>> Didn't work for me ;-(.
>> I've just tested the latest libapreq (commit 1036061) from trunk against
>> perl 5.12.2 with apache 2.2.17 and mod_perl (commit 1029211) and
>> libapreq is passing all tests.
>>
>> Also, I've figured out what that closure error in Registry was - I was
>> running my build script as root, then to run the test suite, was doing:
>>
>> chmod -R a+rwX ./
>> sudo -u nobody make test
>>
>> which meant that the Perl I'd used to build mod_perl was different from
>> the Perl I was using to test it.
>>
>>
>> Does this get us any closer to new releases?
>>
>> thanks
>>
>> Clint
>>
>>
>>
>>
>
>
Re: svn commit: r1035412 - /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Posted by Joe Schaefer <jo...@yahoo.com>.
AFAICT we're just waiting for Issac to start the RM process.
----- Original Message ----
> From: Clinton Gormley <cl...@traveljury.com>
> To: Joe Schaefer <jo...@yahoo.com>
> Cc: apreq-dev <ap...@httpd.apache.org>
> Sent: Thu, November 25, 2010 6:41:56 AM
> Subject: Re: svn commit: r1035412 -
>/httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
>
> On Mon, 2010-11-15 at 11:09 -0800, Joe Schaefer wrote:
> > Didn't work for me ;-(.
>
> I've just tested the latest libapreq (commit 1036061) from trunk against
> perl 5.12.2 with apache 2.2.17 and mod_perl (commit 1029211) and
> libapreq is passing all tests.
>
> Also, I've figured out what that closure error in Registry was - I was
> running my build script as root, then to run the test suite, was doing:
>
> chmod -R a+rwX ./
> sudo -u nobody make test
>
> which meant that the Perl I'd used to build mod_perl was different from
> the Perl I was using to test it.
>
>
> Does this get us any closer to new releases?
>
> thanks
>
> Clint
>
>
>
>
Re: svn commit: r1035412 -
/httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Posted by Clinton Gormley <cl...@traveljury.com>.
On Mon, 2010-11-15 at 11:09 -0800, Joe Schaefer wrote:
> Didn't work for me ;-(.
I've just tested the latest libapreq (commit 1036061) from trunk against
perl 5.12.2 with apache 2.2.17 and mod_perl (commit 1029211) and
libapreq is passing all tests.
Also, I've figured out what that closure error in Registry was - I was
running my build script as root, then to run the test suite, was doing:
chmod -R a+rwX ./
sudo -u nobody make test
which meant that the Perl I'd used to build mod_perl was different from
the Perl I was using to test it.
Does this get us any closer to new releases?
thanks
Clint
Re: svn commit: r1035412 - /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Posted by Joe Schaefer <jo...@yahoo.com>.
Didn't work for me ;-(.
----- Original Message ----
> From: Issac Goldstand <ma...@beamartyr.net>
> To: apreq-dev@httpd.apache.org
> Sent: Mon, November 15, 2010 2:06:29 PM
> Subject: Re: svn commit: r1035412 -
>/httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
>
> What was wrong here? It ran fine by me as-is (and failed without the
> rest of the patch)
>
> On 15/11/2010 21:00, joes@apache.org wrote:
> > Author: joes
> > Date: Mon Nov 15 19:00:28 2010
> > New Revision: 1035412
> >
> > URL: http://svn.apache.org/viewvc?rev=1035412&view=rev
> > Log:
> > fix httponly test
> >
> > Modified:
> > httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
> >
> > Modified: httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
> > URL:
>http://svn.apache.org/viewvc/httpd/apreq/trunk/glue/perl/t/apreq/cookie.t?rev=1035412&r1=1035411&r2=1035412&view=diff
>
> >
>==============================================================================
> > ; --- httpd/apreq/trunk/glue/perl/t/apreq/cookie.t (original)
> > +++ httpd/apreq/trunk/glue/perl/t/apreq/cookie.t Mon Nov 15 19:00:28 2010
> > @@ -172,11 +172,11 @@ my $location = Apache::TestRequest::modu
> > my $test = 'httponly';
> > my $key = 'apache';
> > my $value = 'ok';
> > - my $cookie = "$key=$value; HttpOnly";
> > + my $cookie = "foo=$test; path=/quux; domain=example.com; HttpOnly";
> > my ($header) =
> > GET_HEAD("$location?test=$test&key=$key") =~
>/^#Set-Cookie:\s+(.+)/m;
> >
> > - ok t_cmp($header, $cookie_in, $test);
> > + ok t_cmp($header, $cookie, $test);
> >
> > }
> >
> >
>
>
Re: svn commit: r1035412 - /httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
Posted by Issac Goldstand <ma...@beamartyr.net>.
What was wrong here? It ran fine by me as-is (and failed without the
rest of the patch)
On 15/11/2010 21:00, joes@apache.org wrote:
> Author: joes
> Date: Mon Nov 15 19:00:28 2010
> New Revision: 1035412
>
> URL: http://svn.apache.org/viewvc?rev=1035412&view=rev
> Log:
> fix httponly test
>
> Modified:
> httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
>
> Modified: httpd/apreq/trunk/glue/perl/t/apreq/cookie.t
> URL: http://svn.apache.org/viewvc/httpd/apreq/trunk/glue/perl/t/apreq/cookie.t?rev=1035412&r1=1035411&r2=1035412&view=diff
> ==============================================================================
> --- httpd/apreq/trunk/glue/perl/t/apreq/cookie.t (original)
> +++ httpd/apreq/trunk/glue/perl/t/apreq/cookie.t Mon Nov 15 19:00:28 2010
> @@ -172,11 +172,11 @@ my $location = Apache::TestRequest::modu
> my $test = 'httponly';
> my $key = 'apache';
> my $value = 'ok';
> - my $cookie = "$key=$value; HttpOnly";
> + my $cookie = "foo=$test; path=/quux; domain=example.com; HttpOnly";
> my ($header) =
> GET_HEAD("$location?test=$test&key=$key") =~ /^#Set-Cookie:\s+(.+)/m;
>
> - ok t_cmp($header, $cookie_in, $test);
> + ok t_cmp($header, $cookie, $test);
>
> }
>
>