You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/02 04:48:41 UTC

[GitHub] danny0405 edited a comment on issue #1081: [CALCITE-2888] Enhance RexImplicationChecker to better handle cast

danny0405 edited a comment on issue #1081: [CALCITE-2888] Enhance RexImplicationChecker to better handle cast
URL: https://github.com/apache/calcite/pull/1081#issuecomment-468884621
 
 
   -1, I think it's not a good idea to make so muck changes just to move constant reduction logic into RexImplicationChecker, because there is a rule/rules can do this.
   
   Actually for production, the RexExecutor is pluggable for users, so the cast is not much big problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services