You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/07/11 08:38:47 UTC

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #933: IGNITE-17242 Revise codebase to align logs with proposed guidelines

korlov42 commented on code in PR #933:
URL: https://github.com/apache/ignite-3/pull/933#discussion_r917680856


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java:
##########
@@ -121,12 +121,12 @@ public CompletableFuture<Void> initCluster(
                                 e = e.getCause();
                             }
 
-                            LOG.error("Initialization failed: {}", e, e.getMessage());
+                            LOG.info("Initialization failed [reason={}]", e, e.getMessage());

Review Comment:
   Error is always actionable. At this particular case the exception is returned back to the invoker, so it's up to invoker to decide whether the exception is recoverable or not. If exception is recoverable, then there is no need to bother operation team.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org