You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/13 20:56:55 UTC
[GitHub] [activemq-artemis] erwindon opened a new pull request #3794: ARTEMIS-3461 provide a more native AMQP message represention in browse-queue
erwindon opened a new pull request #3794:
URL: https://github.com/apache/activemq-artemis/pull/3794
added a message viewer for AMQP messages.
the message is used before it is converted to CORE to bypass any conversion errors and to be able to use the original message
WORK IN PROGRESS, DO NOT MERGE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3794: ARTEMIS-3461 provide a more native AMQP message represention in browse-queue
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3794:
URL: https://github.com/apache/activemq-artemis/pull/3794#issuecomment-942835861
this is a bit more intrinsic than what I though... the OpenTypeSupport would have to be moved somewhere else where you can have access on the client as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3794: ARTEMIS-3461 provide a more native AMQP message represention in browse-queue
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3794:
URL: https://github.com/apache/activemq-artemis/pull/3794#discussion_r728659828
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/openmbean/OpenTypeSupport.java
##########
@@ -302,4 +316,30 @@ protected void init() throws OpenDataException {
return rc;
}
}
+
+ static class AmqpMessageOpenTypeFactory extends MessageOpenTypeFactory {
+ protected ArrayType body;
+
+ @Override
+ protected void init() throws OpenDataException {
+ super.init();
+ addItem(CompositeDataConstants.TEXT_BODY, CompositeDataConstants.TEXT_BODY, SimpleType.STRING);
+ }
+
+ @Override
+ public Map<String, Object> getFields(MessageReference ref, int valueSizeLimit) throws OpenDataException {
+ Map<String, Object> rc = super.getFields(ref, valueSizeLimit);
+
+ AMQPStandardMessage amqpMessage = ((AMQPStandardMessage) ref.getMessage());
Review comment:
The intent of protocol support is theyre a layer and self contained within their protocol modules, else we end up having all protocols just mis matching all over the place. Can we look to abstract out and interface whats needed in core server so that protocols can extend and then have protocol specifics in protocol module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3794: ARTEMIS-3461 provide a more native AMQP message represention in browse-queue
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3794:
URL: https://github.com/apache/activemq-artemis/pull/3794#discussion_r728660256
##########
File path: artemis-server/pom.xml
##########
@@ -102,6 +102,11 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
-1 see other comment but core server should be protocol agnostic. Else we loose the clean decoupling between core server and diff protocol supports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3794: ARTEMIS-3461 provide a more native AMQP message represention in browse-queue
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3794:
URL: https://github.com/apache/activemq-artemis/pull/3794#issuecomment-942851639
@erwindon I have a few changes I can improve on this.. I will have to send a PR to your branch tomorrow...
It's 9:00 PM right now on my time zone and I will have to continue this tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org