[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2234: HDDS-5164. Improve client and server logging.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2234:
URL: https://github.com/apache/ozone/pull/2234#discussion_r629873977



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
##########
@@ -193,6 +193,15 @@ private OMResponse submitReadRequestToOM(OMRequest request)
     }
   }
 
+  private ServiceException createLeaderErrorException(

Review comment:
       Minor: Unnecessary code change. I see it is just moved up.

##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -883,6 +885,10 @@ private static StorageContainerLocationProtocol getScmContainerClient(
         false)) {
       rpcServer.refreshServiceAcl(conf, OMPolicyProvider.getInstance());
     }
+
+    rpcServer.addSuppressedLoggingExceptions(OMNotLeaderException.class,

Review comment:
       Good find, so now on server side Rpc does not log these errors.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org