[GitHub] [flink] TisonKun commented on issue #4844: [FLINK-7844] [ckPt] Fail unacknowledged pending checkpoints for fine grained recovery

[GitBox <gi...@apache.org>]

TisonKun commented on issue #4844: [FLINK-7844] [ckPt] Fail unacknowledged pending checkpoints for fine grained recovery
URL: https://github.com/apache/flink/pull/4844#issuecomment-535382660
 
 
   > I would suggest to try and test this without as much mocking. Mockito-based tests have proven very hard to maintain. Mockito is still valuable to mock external systems and dependencies, but for internal APIs, I would refrain from using it as much as possible.
   
   Hi @StephanEwen. Recently I lost the context why we prefer prevent us from using Mockito for internal tests. I found this statement and want to ask again how it "have proven very hard to maintain". I don't find this part in our contributing guide and I think it would be a good part of it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services