You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Yichen Zhou (JIRA)" <ji...@apache.org> on 2018/09/05 03:32:00 UTC

[jira] [Comment Edited] (KYLIN-3521) Enable Cube Planner by default

    [ https://issues.apache.org/jira/browse/KYLIN-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603863#comment-16603863 ] 

Yichen Zhou edited comment on KYLIN-3521 at 9/5/18 3:31 AM:
------------------------------------------------------------

It seems like KYLIN_3521_V2.patch __ forgot to set "kylin.cube.cubeplanner.enabled" to true in _kylin\server\src\test\java\org\apache\kylin\rest\service\AdminServiceTest.java_, which may cause build failure.
 [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.136 s <<< FAILURE! - in org.apache.kylin.rest.service.AdminServiceTest[ERROR] testGetPublicConfig(org.apache.kylin.rest.service.AdminServiceTest) Time elapsed: 0.063 s <<< FAILURE!org.junit.ComparisonFailure: 
 expected:<...cubeplanner.enabled=[fals]e
 kylin.web.help=
 ky...> but was:<...cubeplanner.enabled=[tru]e
 kylin.web.help=
 ky...>
 at org.apache.kylin.rest.service.AdminServiceTest.testGetPublicConfig(AdminServiceTest.java:77)


was (Author: yichen.zhou):
It seems like KYLIN-3521_V2.patch forgot to set "kylin.cube.cubeplanner.enabled" to true in _kylin\server\src\test\java\org\apache\kylin\rest\service\AdminServiceTest.java_, which may cause build failure.
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.136 s <<< FAILURE! - in org.apache.kylin.rest.service.AdminServiceTest[ERROR] testGetPublicConfig(org.apache.kylin.rest.service.AdminServiceTest)  Time elapsed: 0.063 s  <<< FAILURE!org.junit.ComparisonFailure: 
expected:<...cubeplanner.enabled=[fals]e
kylin.web.help=
ky...> but was:<...cubeplanner.enabled=[tru]e
kylin.web.help=
ky...>
	at org.apache.kylin.rest.service.AdminServiceTest.testGetPublicConfig(AdminServiceTest.java:77)

> Enable Cube Planner by default
> ------------------------------
>
>                 Key: KYLIN-3521
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3521
>             Project: Kylin
>          Issue Type: Improvement
>    Affects Versions: v2.5.0
>            Reporter: Shaofeng SHI
>            Assignee: Ma Gang
>            Priority: Minor
>             Fix For: v2.5.0
>
>         Attachments: KYLIN-3521_V2.patch
>
>
> Cube planner can significantly reduce the cuboid number that to build. As it wasn't enabled by default in 2.3 and 2.4, many users don't know that.
>  
> To let more user to start using it, I suggest to enable it by default. 
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)