[GitHub] [helix] rahulrane50 commented on a diff in pull request #2325: Refactor zookeeper-api module with more flexible watcher and connection setup

[GitBox <gi...@apache.org>]

rahulrane50 commented on code in PR #2325:
URL: https://github.com/apache/helix/pull/2325#discussion_r1061001609


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -2499,7 +2503,7 @@ public Object call() throws Exception {
    * @throws IllegalStateException
    *           if the connection timed out due to thread interruption
    */
-  public void connect(final long maxMsToWaitUntilConnected, Watcher watcher)
+  public void connect(final long maxMsToWaitUntilConnected, @Nullable Watcher watcher)

Review Comment:
   Umm if it's not expected then it's fine. I was just thinking that it should not be silently ignored because of this Nullable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org