You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2017/03/28 16:28:31 UTC

[GitHub] zeppelin pull request #2198: [ZEPPELIN-2318] Fix proxy configuration for htt...

GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/2198

    [ZEPPELIN-2318] Fix proxy configuration for http client of zeppelinhub storage layer

    ### What is this PR for?
    it fixes proxy configuration for http client of zeppelinhub storage layer. currently used jetty-client have issue with `https` over proxy ([1](https://github.com/eclipse/jetty.project/issues/408), [2](https://github.com/eclipse/jetty.project/issues/827)), so new `httpcomponents` library have been used. 
    
    ### What type of PR is it?
    Bug Fix | Improvement
    
    ### Todos
    * [x] - implement whole client with proxy
    
    ### What is the Jira issue?
    [ZEPPELIN-2318](https://issues.apache.org/jira/browse/ZEPPELIN-2318)
    
    ### How should this be tested?
    1. setup proxy and make system point to it (e.g. env should contain `https_proxy`)
    2. setup storage (e.g. [here](https://zeppelin.apache.org/docs/0.7.0/storage/storage.html#storage-in-zeppelinhub))
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2318

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2198
    
----
commit d2dab6c9654ec2604fae661bdaa7337136e9474a
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-03-28T12:57:48Z

    add dependency on asyncclient

commit 16ccbb46169ca8ac546d389100d83da7597fb4f5
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-03-28T12:58:59Z

    add proxy client with asynclient library

commit a5711bc1dd47531b661183e02319490c8927e887
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-03-28T13:00:21Z

    jetty client relay to asyncclient when proxy on

commit 8cb94006c7e5ab99767fcc214a5eeba6cec2750b
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-03-28T13:01:01Z

    add close routine

commit db07f5b569608b9a008a8798e10c63a23df12ccf
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-03-28T15:40:03Z

    add ssl setup

commit 72fa4f12d98e983da1233e94609e0a57683561d5
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-03-28T15:40:37Z

    fix trans dependency problem

commit 409993a8ee9f15192af105499f989a94961a92aa
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-03-28T16:13:09Z

    fix websocket timing

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2198: [ZEPPELIN-2318] Fix proxy configuration for http clien...

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2198
  
    merge into master and branch-0.7 if no further comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2198: [ZEPPELIN-2318] Fix proxy configuration for http clien...

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/2198
  
    @felixcheung right `warning` level makes more sense in those cases, addressed in 8ea7d5d9652fa00d00cb6d749f0e1e718beb8c95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2198: [ZEPPELIN-2318] Fix proxy configuration for htt...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2198


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---