You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/09 19:27:55 UTC

[GitHub] [ozone] ayushtkn commented on a change in pull request #1894: HDDS-4792. Remove redundant state check for handleDeleteChunk

ayushtkn commented on a change in pull request #1894:
URL: https://github.com/apache/ozone/pull/1894#discussion_r573173675



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
##########
@@ -653,14 +653,6 @@ ContainerCommandResponseProto handleDeleteChunk(
       return malformedRequest(request);
     }
 
-    // The container can become unhealthy after the lock is released.
-    // The operation will likely fail/timeout in that happens.
-    try {
-      checkContainerIsHealthy(kvContainer);
-    } catch (StorageContainerException sce) {
-      return ContainerUtils.logAndReturnError(LOG, sce, request);
-    }

Review comment:
       Where is this check available in ``handleDeleteChunk`` path? I tried checking callers of the method, couldn't find where this is checked before. Can you point me to that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org