[jira] [Comment Edited] (GEODE-4885) DistributedRestoreSystemPropertiesTest is failing

["Kirk Lund (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405355#comment-16405355 ] 

Kirk Lund edited comment on GEODE-4885 at 3/19/18 9:00 PM:
-----------------------------------------------------------

I changed DUnitLauncher.launchIfNeeded() to throw an Error and this only shows up for ShowLogCommandDUnitTest. The others show up in the JUnit report for "test" with zero tests, zero failures, zero ignored. The custom Runners for parameters seem to forcing the gradle junit plugin to instantiate the class in order to examine the Categories but only for the ones that have the custom runners.


was (Author: klund):
I changed DUnitLauncher.launchIfNeeded() to throw an Error and this only shows up for ShowLogCommandDUnitTest. The others show up in the JUnit report for "test" with zero tests, zero failures, zero ignored. The customer Runners for parameters seem to forcing the gradle junit plugin to instantiate the class in order to examine the Categories but only for the ones that have the custom runners.

> DistributedRestoreSystemPropertiesTest is failing
> -------------------------------------------------
>
>                 Key: GEODE-4885
>                 URL: https://issues.apache.org/jira/browse/GEODE-4885
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Jens Deppe
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This test is supposedly checking for any {{DUnitTest}} that inadvertently runs under the {{test}} gradle task or, more specifically, is categorized as a {{UnitTest}}.
> Unfortunately, due to the way that Junit determines what category a test is in (by creating an instance of the class), it will also invoke any static declarations. It also triggers parameterized values. The result is that some {{DistributedTests}} actually end up launching DUnit VMs even though the actual tests don't run. Depending on test ordering this can lead to {{DistributedRestoreSystemPropertiesTest}} failing intermittently.
> By examining the test report, it appears that the following DUnit tests are triggering this problem:
> {noformat}
> org.apache.geode.management.internal.cli.commands.ShowLogCommandDUnitTest
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest
> org.apache.geode.security.ClientAuthenticationPart2DUnitTest
> org.apache.geode.cache.lucene.LuceneCommandsSecurityDUnitTest
> org.apache.geode.management.internal.configuration.ClusterConfigurationIndexWithFromClauseDUnitTest
> org.apache.geode.internal.cache.tier.sockets.ClientServerMiscBCDUnitTest
> org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit
> org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest
> org.apache.geode.internal.cache.rollingupgrade.RollingUpgrade2DUnitTest
> org.apache.geode.security.ClientAuthenticationDUnitTest
> org.apache.geode.security.ClientAuthorizationCQDUnitTest
> org.apache.geode.internal.cache.TxCommitMessageBackwardCompatibilityDUnitTest
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)