You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/02 06:37:02 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #8091: ARROW-9873: [C++][Compute] Optimize mode kernel for integers in small value range

cyb70289 commented on a change in pull request #8091:
URL: https://github.com/apache/arrow/pull/8091#discussion_r481789852



##########
File path: cpp/src/arrow/compute/kernels/aggregate_mode.cc
##########
@@ -26,95 +26,187 @@ namespace aggregate {
 
 namespace {
 
+// Count values and return value:count map
+template <typename T>
+struct ValueCounter {
+  virtual void CountOne(T value) = 0;

Review comment:
       Changed to template. Did get better performance. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org