[kudu-CR] replace nvml with memkind in block cache

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )

Change subject: replace nvml with memkind in block cache
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13188/1/src/kudu/util/nvm_cache.cc
File src/kudu/util/nvm_cache.cc:

http://gerrit.cloudera.org:8080/#/c/13188/1/src/kudu/util/nvm_cache.cc@54
PS1, Line 54: // Useful in tests that require accurate cache capacity accounting.
            : DEFINE_bool(nvm_cache_force_single_shard, false,
            :            "Override all cache implementations to use just one shard");
            : TAG_FLAG(nvm_cache_force_single_shard, hidden);
According to the comment, this is targeted for tests only.  If so, why not to use already existing 'cache_force_single_shard' flag then?


http://gerrit.cloudera.org:8080/#/c/13188/1/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/13188/1/thirdparty/vars.sh@169
PS1, Line 169: MEMKIND_VERSION=1.7.0
2019-04-02 memkind v1.9.0 was released.  Does it make sense to  use the latest version instead of 1.7.0?



-- 
To view, visit http://gerrit.cloudera.org:8080/13188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5
Gerrit-Change-Number: 13188
Gerrit-PatchSet: 1
Gerrit-Owner: ye yuqiang <yu...@intel.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 02 May 2019 18:54:22 +0000
Gerrit-HasComments: Yes