You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:53:57 UTC

[GitHub] [samza] bkonold commented on a change in pull request #1405: SAMZA-2570: Add app.env into configs

bkonold commented on a change in pull request #1405:
URL: https://github.com/apache/samza/pull/1405#discussion_r461953777



##########
File path: samza-core/src/main/java/org/apache/samza/util/Util.java
##########
@@ -51,6 +51,10 @@ public static String envVarEscape(String str) {
         .replace("`", "\\`");
   }
 
+  public static String getAppEnv(Config config) {
+    return new ApplicationConfig(config).getAppEnv();
+  }
+

Review comment:
       Why do we need this if we already have the accessor in ApplicationConfig?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org