[Impala-ASF-CR] IMPALA-9196: Dump jstack and collect logs when tests timeout

["Joe McDonnell (Code Review)" <ge...@cloudera.org>]

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14794 )

Change subject: IMPALA-9196: Dump jstack and collect logs when tests timeout
......................................................................


Patch Set 2:

> I'm uncertain about how the privileges work. There are ptrace
 > limitations in Ubuntu that restrict ptrace by the same user to a
 > parent process, which I think is why the gdb part of this script
 > works. I'm not sure what permissions jstack would need, and if this
 > would work.
 > 
 > If you haven't already, a test that you could run for the
 > permissions is to run the end to end tests and set
 > TIMEOUT_FOR_RUN_ALL_TESTS_MINS to some modest value (15 mins) and
 > verify you get the logs you want and jstack works.
 > 
 > Once we verify that the permissions are ok in the normal way we run
 > this, the code looks good to me.

Circling back to this review. My guess is that this doesn't work in its current form on Ubuntu, but it might work on other platforms.

It looks like it is harmless if these debug commands fail (because the script doesn't have "set -euo pipefail"). I think any step forward in this debugging information is ok to merge as long as it improves some platform without regressing anything. We should add comments about dump statements that don't work on some platforms, but that shouldn't stop us from adding statements that do work on Centos7 or some other platform. Obviously, it would be nice for these things to work on Ubuntu.


-- 
To view, visit http://gerrit.cloudera.org:8080/14794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8a5b140024c236209c7e44149660189890b9d06
Gerrit-Change-Number: 14794
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 18:38:46 +0000
Gerrit-HasComments: No