[jira] [Closed] (THRIFT-1801) Sync up TApplicationException codes across languages and thrift implementations

["Jake Farrell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-1801.
--------------------------------

    Resolution: Fixed

Closing since code is already committed and ticket has lagged in response since

> Sync up TApplicationException codes across languages and thrift implementations
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-1801
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1801
>             Project: Thrift
>          Issue Type: Task
>    Affects Versions: 1.0
>         Environment: all
>            Reporter: Andrew Cox
>            Assignee: Andrew Cox
>             Fix For: 1.0
>
>         Attachments: THRIFT-1801.1.patch
>
>
> Two issues with TApplicationException codes: 
> 1) some languages contained incomplete lists of existing TApplicationException codes
> 2) internally in Facebook thrift servers, we had reserved a few extra error codes for TApplicationException, and those error codes were then claimed here for different uses. this causes conflicts when some clients that know about one set of codes communicates with servers that know about a different set of codes. I've reassigned our internal error code numbers to make space for the ones in more recent thrift code, but to try prevent this from happening again, I'd like to add our own codes to reserve them (these currently won't have any other mention in the thrift libraries right now than being in TApplicationException, but they may eventually be used when we push more of this internal code out).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)