[GitHub] [maven-shade-plugin] famod commented on issue #35: [MSHADE-311] - Don't add exclusions for provided dep

[GitBox <gi...@apache.org>]

famod commented on issue #35: [MSHADE-311] - Don't add exclusions for provided dep
URL: https://github.com/apache/maven-shade-plugin/pull/35#issuecomment-570612246
 
 
   Btw: I find it very unfortunate that back then MSHADE-31 did _not_ introduce a test.
   So my new integration test seems to be the first test actually testing the dependency reduced POM for the presence/absence of `exclusions` (but only for a very specific scenario).
   
   In case `prodvided` scope dependencies are ever fully adressed by this plugin (which would make sense by the way, see also [MSHADE-89](http://jira.codehaus.org/browse/MSHADE-89) and [MSHADE-181](http://jira.codehaus.org/browse/MSHADE-181)), the entire `exclusions` handling should be re-implemented. The current approach might have been influenced by older Maven versions, but from a recent POV: Why isn't the Plugin just checking the original exclusions of the original pom? Instead is is (IMHO) trying to "guess" what _might_ have been an exclusion before all the shading.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services