You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/11/26 06:45:02 UTC
[kudu-CR] txns: use HostPorts instead of strings to build TxnSystemClient
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16787
to review the following change.
Change subject: txns: use HostPorts instead of strings to build TxnSystemClient
......................................................................
txns: use HostPorts instead of strings to build TxnSystemClient
Strings are the inputs for the ClientBuilder, but in most tests, we have
HostPorts available. Rather than converting at all the call-sites, this
patch converts the constructor to HostPorts instead.
Change-Id: I92a09a256e84020756f3073cd7289a2245058e4a
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
8 files changed, 18 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/16787/1
--
To view, visit http://gerrit.cloudera.org:8080/16787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92a09a256e84020756f3073cd7289a2245058e4a
Gerrit-Change-Number: 16787
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] txns: use HostPorts instead of strings to build TxnSystemClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16787
to look at the new patch set (#2).
Change subject: txns: use HostPorts instead of strings to build TxnSystemClient
......................................................................
txns: use HostPorts instead of strings to build TxnSystemClient
Strings are the inputs for the ClientBuilder, but in most tests, we have
HostPorts available, so we currently convert the master addresses to a
vector<string> and pass it to the TxnSystemClient consturctor. Rather
than converting at all the call-sites, this patch converts the
constructor to use HostPorts instead.
Change-Id: I92a09a256e84020756f3073cd7289a2245058e4a
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
8 files changed, 18 insertions(+), 44 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/16787/2
--
To view, visit http://gerrit.cloudera.org:8080/16787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I92a09a256e84020756f3073cd7289a2245058e4a
Gerrit-Change-Number: 16787
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] txns: use HostPorts instead of strings to build TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16787 )
Change subject: txns: use HostPorts instead of strings to build TxnSystemClient
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92a09a256e84020756f3073cd7289a2245058e4a
Gerrit-Change-Number: 16787
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Nov 2020 05:42:55 +0000
Gerrit-HasComments: No
[kudu-CR] txns: use HostPorts instead of strings to build TxnSystemClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16787 )
Change subject: txns: use HostPorts instead of strings to build TxnSystemClient
......................................................................
txns: use HostPorts instead of strings to build TxnSystemClient
Strings are the inputs for the ClientBuilder, but in most tests, we have
HostPorts available, so we currently convert the master addresses to a
vector<string> and pass it to the TxnSystemClient consturctor. Rather
than converting at all the call-sites, this patch converts the
constructor to use HostPorts instead.
Change-Id: I92a09a256e84020756f3073cd7289a2245058e4a
Reviewed-on: http://gerrit.cloudera.org:8080/16787
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/master_authz-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/master/txn_manager.cc
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
8 files changed, 18 insertions(+), 44 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I92a09a256e84020756f3073cd7289a2245058e4a
Gerrit-Change-Number: 16787
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)