[GitHub] [ozone] neils-dev commented on a diff in pull request #3847: HDDS-3419. Throw exception with correct code when healthy nodes are not sufficient

[GitBox <gi...@apache.org>]

neils-dev commented on code in PR #3847:
URL: https://github.com/apache/ozone/pull/3847#discussion_r999921701


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java:
##########
@@ -124,6 +124,15 @@ List<DatanodeDetails> filterViableNodes(
     // get nodes in HEALTHY state
     List<DatanodeDetails> healthyNodes =
         nodeManager.getNodes(NodeStatus.inServiceHealthy());
+    if (healthyNodes.size() < nodesRequired) {

Review Comment:
   @kerneltime, this patch looks to correct the failing disabled integration test, `TestRatisPipelineCreateAndDestroy.testPipelineCreationOnNodeRestart.`  The test fails because the exception thrown in the test differs from the expected exception.  The patch ensures the expected exception is thrown.  @pratapchandu, thanks for filing the PR.  Updating the Jira with a brief description of the error would also be helpful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org