You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by de...@apache.org on 2017/09/16 05:46:40 UTC
[myfaces-tobago] 08/10: cosmetic: avoid superfluous scrollbars in
tabs for Richmond theme and make sure inner dimensions are correctly
propagated to tabs, because tabs currently have no default layout manager
This is an automated email from the ASF dual-hosted git repository.
deki pushed a commit to tag tobago-1.0.11
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit bee15ca6446f0bba82ae2eb53a6b8f920badcffa
Author: Bernd Bohmann <bo...@apache.org>
AuthorDate: Wed May 23 20:50:11 2007 +0000
cosmetic: avoid superfluous scrollbars in tabs for Richmond theme and make sure inner dimensions are correctly propagated to tabs, because tabs currently have no default layout manager
---
example/demo/src/main/webapp/overview/tab.jsp | 132 ++++++++++-----------
.../property/tobago-theme-config.properties | 2 +-
2 files changed, 61 insertions(+), 73 deletions(-)
diff --git a/example/demo/src/main/webapp/overview/tab.jsp b/example/demo/src/main/webapp/overview/tab.jsp
index f32a968..a595b7c 100644
--- a/example/demo/src/main/webapp/overview/tab.jsp
+++ b/example/demo/src/main/webapp/overview/tab.jsp
@@ -37,46 +37,40 @@
<tc:tabGroup id="tabMarsOuterForm" state="#{demo.tabState1}" >
<tc:tab label="#{overviewBundle.tabPlanet}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].diameter}"
- label="#{overviewBundle.solarPlanetDiameter}" />
- <tx:in value="#{demo.solar.planets[0].mass}"
- label="#{overviewBundle.solarPlanetMass}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].diameter}"
+ label="#{overviewBundle.solarPlanetDiameter}" />
+ <tx:in value="#{demo.solar.planets[0].mass}"
+ label="#{overviewBundle.solarPlanetMass}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabInsolar}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].sunDistance}"
- label="#{overviewBundle.solarPlanetSunDistance}" />
- <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
- label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].sunDistance}"
+ label="#{overviewBundle.solarPlanetSunDistance}" />
+ <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
+ label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabMoons}">
- <tc:panel>
- <f:facet name="layout"><tc:gridLayout /></f:facet>
- <tc:sheet value="#{demo.solar.planets[0].moons}"
- columns="2*;1*;2*;2*" var="moon">
- <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
- <tc:out value="#{moon.name}" id="t_name" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
- <tc:out value="#{moon.number}" id="t_number"/>
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
- <tc:out value="#{moon.distance}" id="t_distance" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
- <tc:out value="#{moon.period}" id="t_period" />
- </tc:column>
- </tc:sheet>
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout /></f:facet>
+ <tc:sheet value="#{demo.solar.planets[0].moons}"
+ columns="2*;1*;2*;2*" var="moon">
+ <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
+ <tc:out value="#{moon.name}" id="t_name" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
+ <tc:out value="#{moon.number}" id="t_number"/>
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
+ <tc:out value="#{moon.distance}" id="t_distance" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
+ <tc:out value="#{moon.period}" id="t_period" />
+ </tc:column>
+ </tc:sheet>
</tc:tab>
</tc:tabGroup>
@@ -90,46 +84,40 @@
binding="#{demo.tabChangeListener}" />
<tc:tab label="#{overviewBundle.tabPlanet}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].diameter}"
- label="#{overviewBundle.solarPlanetDiameter}" />
- <tx:in value="#{demo.solar.planets[0].mass}"
- label="#{overviewBundle.solarPlanetMass}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].diameter}"
+ label="#{overviewBundle.solarPlanetDiameter}" />
+ <tx:in value="#{demo.solar.planets[0].mass}"
+ label="#{overviewBundle.solarPlanetMass}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabInsolar}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].sunDistance}"
- label="#{overviewBundle.solarPlanetSunDistance}" />
- <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
- label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].sunDistance}"
+ label="#{overviewBundle.solarPlanetSunDistance}" />
+ <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
+ label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabMoons}">
- <tc:panel>
- <f:facet name="layout"><tc:gridLayout /></f:facet>
- <tc:sheet value="#{demo.solar.planets[0].moons}"
- columns="2*;1*;2*;2*" var="moon">
- <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
- <tc:out value="#{moon.name}" id="t_name" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
- <tc:out value="#{moon.number}" id="t_number"/>
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
- <tc:out value="#{moon.distance}" id="t_distance" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
- <tc:out value="#{moon.period}" id="t_period" />
- </tc:column>
- </tc:sheet>
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout /></f:facet>
+ <tc:sheet value="#{demo.solar.planets[0].moons}"
+ columns="2*;1*;2*;2*" var="moon">
+ <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
+ <tc:out value="#{moon.name}" id="t_name" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
+ <tc:out value="#{moon.number}" id="t_number"/>
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
+ <tc:out value="#{moon.distance}" id="t_distance" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
+ <tc:out value="#{moon.period}" id="t_period" />
+ </tc:column>
+ </tc:sheet>
</tc:tab>
</tc:tabGroup>
diff --git a/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties b/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties
index 97826dd..9eac81d 100644
--- a/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties
+++ b/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties
@@ -17,6 +17,6 @@
# padding-top + padding-bottom + border-top + border-bottom
-TabGroup.paddingHeight=27
+TabGroup.paddingHeight=28
# padding-left + padding-right + border-left + border-right
TabGroup.paddingWidth=25
--
To stop receiving notification emails like this one, please contact
"commits@myfaces.apache.org" <co...@myfaces.apache.org>.