You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/08 21:55:42 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #2482: CALCITE-4702 - Error when executing query with GROUP BY constant via JDBC adapter

julianhyde commented on a change in pull request #2482:
URL: https://github.com/apache/calcite/pull/2482#discussion_r765275711



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java
##########
@@ -712,6 +712,20 @@ public boolean supportsCharSet() {
     return true;
   }
 
+  /**
+   * Returns whether the dialect supports group by with boolean constants.

Review comment:
       capitalize GROUP BY and BOOLEAN




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org