[GitHub] [spark] grundprinzip commented on a diff in pull request #38374: [SPARK-40899] [CONNECT] Make UserContext extensible.

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #38374:
URL: https://github.com/apache/spark/pull/38374#discussion_r1003597948


##########
connector/connect/src/main/protobuf/spark/connect/base.proto:
##########
@@ -51,6 +52,12 @@ message Request {
   message UserContext {
     string user_id = 1;
     string user_name = 2;
+
+    // To extend the existing user context message that is used to identify incoming requests,
+    // Spark Connect leverages the Any protobuf type that can be used to inject arbitrary other
+    // messages into this message. Extensions are stored as a `repeated` type to be able to
+    // handle multiple active extensions.
+    repeated google.protobuf.Any extensions = 999;

Review Comment:
   No any is just used to define extension points in the proto so that at the point of writing the proto we don't need to define message that is embedded in the proto.
   
   Interpreting the serialized class is up to the consumer and follows the same security model as any other serialized code so we have to be careful but it's not a new threat. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org