You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/14 07:26:11 UTC
[GitHub] flink pull request #4330: [FLINK-7176] [travis] Improve error handling
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4330
[FLINK-7176] [travis] Improve error handling
1.4 version of #4329.
Additional changes:
- tests are only executed if the compilation was successful
- yarn tests log upload is only done in group that actually runs flink-yarn-tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4330
----
commit 8622d116eeb18ff38a2247f6e916a515dd81bbac
Author: zentol <ch...@apache.org>
Date: 2017-07-13T15:53:40Z
[FLINK-7176] [travis] Improve error handling
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4330: [FLINK-7176] [travis] Improve error handling
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4330: [FLINK-7176] [travis] Improve error handling
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4330
I did tests where the "successful" check returned 1, and it had the correct effect of failing the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4330: [FLINK-7176] [travis] Improve error handling
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4330
+1
I wouldn't say, `return`is uncommon inside a bash function!
`exit` in these methods would immediately exit the bash script while `return` does what is expected here which still allows the `transfer.sh` uploads
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4330: [FLINK-7176] [travis] Improve error handling
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4330
LGTM!
Did you ever encounter the case where the new `return 1` statements were triggered? I think `return` in bash can be a bit "unexpected".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---