[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20451: fix: should raise exception when apply a categorical axis

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20451:
URL: https://github.com/apache/superset/pull/20451#discussion_r914347869


##########
superset/common/query_context_processor.py:
##########
@@ -322,6 +322,16 @@ def processing_time_offsets(  # pylint: disable=too-many-locals
                 #  multi-dimensional charts
                 granularity = query_object.granularity
                 index = granularity if granularity in df.columns else DTTM_ALIAS
+                if not pd.api.types.is_datetime64_any_dtype(

Review Comment:
   I will open a new PR and depend on the Generic Type of column instead of Pandas type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org