You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "irenjj (via GitHub)" <gi...@apache.org> on 2024/11/10 15:53:12 UTC
[PR] Migrate code from invoke to invoke_batch. [datafusion]
irenjj opened a new pull request, #13345:
URL: https://github.com/apache/datafusion/pull/13345
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #13238
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Migrate code in unit test from invoke to invoke_batch.
## Are these changes tested?
yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Migrate code from invoke to invoke_batch. [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #13345:
URL: https://github.com/apache/datafusion/pull/13345#discussion_r1835746256
##########
datafusion/functions/src/datetime/date_bin.rs:
##########
@@ -491,150 +491,197 @@ mod tests {
use chrono::TimeDelta;
#[test]
- #[allow(deprecated)] // TODO migrate UDF invoke to invoke_batch
fn test_date_bin() {
- let res = DateBinFunc::new().invoke(&[
- ColumnarValue::Scalar(ScalarValue::IntervalDayTime(Some(IntervalDayTime {
- days: 0,
- milliseconds: 1,
- }))),
- ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
- ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
- ]);
+ let res = DateBinFunc::new().invoke_batch(
+ &[
+ ColumnarValue::Scalar(ScalarValue::IntervalDayTime(Some(
+ IntervalDayTime {
+ days: 0,
+ milliseconds: 1,
+ },
+ ))),
+ ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
+ ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
+ ],
+ 0,
Review Comment:
would 1 be more suitable?
(same in other places)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Migrate code from invoke to invoke_batch. [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #13345:
URL: https://github.com/apache/datafusion/pull/13345#issuecomment-2476049846
Thank you @irenjj @jayzhan211 @alamb .
it looks ready to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Migrate code from invoke to invoke_batch. [datafusion]
Posted by "irenjj (via GitHub)" <gi...@apache.org>.
irenjj commented on PR #13345:
URL: https://github.com/apache/datafusion/pull/13345#issuecomment-2466786692
PTAL @findepi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Migrate code from invoke to invoke_batch. [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #13345:
URL: https://github.com/apache/datafusion/pull/13345#issuecomment-2473183998
Thank you very much @irenjj and @findepi and @jayzhan211 -- I merged this branch up from main to run CI against the latest and greatest versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Migrate code from invoke to invoke_batch. [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #13345:
URL: https://github.com/apache/datafusion/pull/13345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org