You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2023/05/21 23:42:16 UTC

[spark] branch master updated: [SPARK-43599][CONNECT][BUILD] Upgrade buf to v1.19.0

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new e186e9dfbf1 [SPARK-43599][CONNECT][BUILD] Upgrade buf to v1.19.0
e186e9dfbf1 is described below

commit e186e9dfbf119abab68a782617d3b1d5f973ea6e
Author: panbingkun <pb...@gmail.com>
AuthorDate: Sun May 21 16:41:58 2023 -0700

    [SPARK-43599][CONNECT][BUILD] Upgrade buf to v1.19.0
    
    ### What changes were proposed in this pull request?
    The pr aims to upgrade buf from 1.18.0 to 1.19.0
    
    ### Why are the changes needed?
    1.Release Notes: https://github.com/bufbuild/buf/releases, bug fixed as follow:
    - Fix issue in buf build and buf generate where the use of type filtering (via --type flags) would cause the resulting image to have no source code info, even when --exclude-source-info was not specified. The main impact of the bug was that
    generated code would be missing comments.
    - Fix issue in buf curl when using --user or --netrc that would cause a malformed Authorization header to be sent.
    
    2.https://github.com/bufbuild/buf/compare/v1.18.0...v1.19.0
    
    3.Manually test: dev/connect-gen-protos.sh, this upgrade will not change the generated files.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Manually test and Pass GA.
    
    Closes #41246 from panbingkun/SPARK-43599.
    
    Authored-by: panbingkun <pb...@gmail.com>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 .github/workflows/build_and_test.yml            | 2 +-
 python/docs/source/development/contributing.rst | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
index 580415540a6..75d37971d96 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -616,7 +616,7 @@ jobs:
     - name: Install dependencies for Python code generation check
       run: |
         # See more in "Installation" https://docs.buf.build/installation#tarball
-        curl -LO https://github.com/bufbuild/buf/releases/download/v1.18.0/buf-Linux-x86_64.tar.gz
+        curl -LO https://github.com/bufbuild/buf/releases/download/v1.19.0/buf-Linux-x86_64.tar.gz
         mkdir -p $HOME/buf
         tar -xvzf buf-Linux-x86_64.tar.gz -C $HOME/buf --strip-components 1
         python3.9 -m pip install 'protobuf==3.19.5' 'mypy-protobuf==3.3.0'
diff --git a/python/docs/source/development/contributing.rst b/python/docs/source/development/contributing.rst
index 8b9a9899b6d..885ab8d8cba 100644
--- a/python/docs/source/development/contributing.rst
+++ b/python/docs/source/development/contributing.rst
@@ -120,7 +120,7 @@ Prerequisite
 
 PySpark development requires to build Spark that needs a proper JDK installed, etc. See `Building Spark <https://spark.apache.org/docs/latest/building-spark.html>`_ for more details.
 
-Note that if you intend to contribute to Spark Connect in Python, ``buf`` version ``1.18.0`` is required, see `Buf Installation <https://docs.buf.build/installation>`_ for more details.
+Note that if you intend to contribute to Spark Connect in Python, ``buf`` version ``1.19.0`` is required, see `Buf Installation <https://docs.buf.build/installation>`_ for more details.
 
 Conda
 ~~~~~


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org