You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by elmalto <gi...@git.apache.org> on 2014/09/24 20:34:59 UTC
[GitHub] spark pull request: logNormalGraph missing partition parameter
GitHub user elmalto opened a pull request:
https://github.com/apache/spark/pull/2523
logNormalGraph missing partition parameter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elmalto/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2523
----
commit 5478e716b9f080b7419285752708f0f4050f23da
Author: elmalto <el...@users.noreply.github.com>
Date: 2014-09-24T18:34:45Z
logNormalGraph missing partition parameter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: logNormalGraph missing partition parameter
Posted by ankurdave <gi...@git.apache.org>.
Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/2523#issuecomment-56742910
Thanks! Just a minor thing -- it would be good to use the argument name as follows:
```scala
val graph: Graph[Double, Int] =
GraphGenerators.logNormalGraph(sc, numVertices = 100,
numEParts = sc.defaultParallelism).mapVertices( (id, _) => id.toDouble )
```
ok to test (though it's only a doc change)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: logNormalGraph missing partition parameter
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2523#issuecomment-56717691
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] logNormalGraph missing partition parame...
Posted by elmalto <gi...@git.apache.org>.
Github user elmalto commented on the pull request:
https://github.com/apache/spark/pull/2523#issuecomment-58249966
For some reason I cannot change the pull request itself
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] logNormalGraph missing partition parame...
Posted by elmalto <gi...@git.apache.org>.
Github user elmalto closed the pull request at:
https://github.com/apache/spark/pull/2523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] logNormalGraph missing partition parame...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2523#issuecomment-58739482
@elmalto It looks like GitHub says that this PR was opened from "unknown repository", which might explain why you're not able to update its code. If that's the case, could you close this PR and open a new one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] logNormalGraph missing partition parame...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2523#discussion_r18541629
--- Diff: docs/graphx-programming-guide.md ---
@@ -620,7 +620,7 @@ more senior followers of each user.
import org.apache.spark.graphx.util.GraphGenerators
// Create a graph with "age" as the vertex property. Here we use a random graph for simplicity.
val graph: Graph[Double, Int] =
- GraphGenerators.logNormalGraph(sc, numVertices = 100).mapVertices( (id, _) => id.toDouble )
+ GraphGenerators.logNormalGraph(sc, numVertices = 100,sc.defaultParallelism).mapVertices( (id, _) => id.toDouble )
--- End diff --
I can't help myself to pedantry while you're here: space before `sc` please!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] logNormalGraph missing partition parame...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2523#discussion_r18545622
--- Diff: docs/graphx-programming-guide.md ---
@@ -620,7 +620,7 @@ more senior followers of each user.
import org.apache.spark.graphx.util.GraphGenerators
// Create a graph with "age" as the vertex property. Here we use a random graph for simplicity.
val graph: Graph[Double, Int] =
- GraphGenerators.logNormalGraph(sc, numVertices = 100).mapVertices( (id, _) => id.toDouble )
+ GraphGenerators.logNormalGraph(sc, numVertices = 100,sc.defaultParallelism).mapVertices( (id, _) => id.toDouble )
--- End diff --
+1, also no space before `)`, and I would just put `.mapVertices` on the next line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: logNormalGraph missing partition parameter
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2523#issuecomment-58240382
Hey @elmalto could you add `[Docs]` to the title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org