[jira] [Commented] (STORM-723) [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation

["Jungtaek Lim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379062#comment-14379062 ] 

Jungtaek Lim commented on STORM-723:
------------------------------------

[~dashengju] [~revans2]
I'd like to hear your opinion about RedisStateSetUpdater and RedisStateSetCountQuerier.
If it cannot be replaced with other logic, how about removing these classes?

If we have to support 'expires on value', it may be better to support only String type from Trident.

> [storm-redis] RedisStateSetUpdater writes state into String but calls Set operation
> -----------------------------------------------------------------------------------
>
>                 Key: STORM-723
>                 URL: https://issues.apache.org/jira/browse/STORM-723
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> RedisStateSetUpdater writes value into String type, but it tries to retrieve Set's element count from String type which will throw JedisDataException. 
> {code}
>                 if (this.expireIntervalSec > 0) {
>                     jedis.setex(redisKey, expireIntervalSec, value);
>                 } else {
>                     jedis.set(redisKey, value);
>                 }
>                 Long count = jedis.scard(redisKey);
> {code}
> Btw, Redis expire only applies to key, so above implementation seems to be invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)