You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/02/14 03:55:39 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #599: [MINOR] chore: remove duplicated dependency in rss-client-mr
kaijchen opened a new pull request, #599:
URL: https://github.com/apache/incubator-uniffle/pull/599
### What changes were proposed in this pull request?
Remove duplicated dependency in `rss-client-mr`.
### Why are the changes needed?
Dependency `rss-client` is duplicated.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #599: [MINOR] chore: remove duplicated dependency in rss-client-mr
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #599:
URL: https://github.com/apache/incubator-uniffle/pull/599#issuecomment-1429084719
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#599](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b6a5b66) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/7a8cdb044ddf19a5f659bd3879945fb41cd9329c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a8cdb0) will **decrease** coverage by `12.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #599 +/- ##
=============================================
- Coverage 60.85% 48.80% -12.05%
=============================================
Files 214 14 -200
Lines 12387 1971 -10416
Branches 1044 0 -1044
=============================================
- Hits 7538 962 -6576
+ Misses 4444 949 -3495
+ Partials 405 60 -345
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/uniffle/server/ShuffleServerGrpcMetrics.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyR3JwY01ldHJpY3MuamF2YQ==) | | |
| [...org/apache/uniffle/server/ShuffleFlushManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlRmx1c2hNYW5hZ2VyLmphdmE=) | | |
| [...niffle/common/security/SecurityContextFactory.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9zZWN1cml0eS9TZWN1cml0eUNvbnRleHRGYWN0b3J5LmphdmE=) | | |
| [...torage/handler/impl/AbstractClientReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9BYnN0cmFjdENsaWVudFJlYWRIYW5kbGVyLmphdmE=) | | |
| [...rategy/partition/RoundSelectPartitionStrategy.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivc3RyYXRlZ3kvcGFydGl0aW9uL1JvdW5kU2VsZWN0UGFydGl0aW9uU3RyYXRlZ3kuamF2YQ==) | | |
| [...a/org/apache/uniffle/coordinator/QuotaManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvUXVvdGFNYW5hZ2VyLmphdmE=) | | |
| [...g/apache/uniffle/common/storage/StorageStatus.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9zdG9yYWdlL1N0b3JhZ2VTdGF0dXMuamF2YQ==) | | |
| [...rg/apache/uniffle/storage/common/LocalStorage.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2NvbW1vbi9Mb2NhbFN0b3JhZ2UuamF2YQ==) | | |
| [...ache/uniffle/storage/handler/impl/FileSegment.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9GaWxlU2VnbWVudC5qYXZh) | | |
| [...uniffle/common/segment/SegmentSplitterFactory.java](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9zZWdtZW50L1NlZ21lbnRTcGxpdHRlckZhY3RvcnkuamF2YQ==) | | |
| ... and [190 more](https://codecov.io/gh/apache/incubator-uniffle/pull/599?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #599: [MINOR] chore: remove duplicated dependency in rss-client-mr
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #599:
URL: https://github.com/apache/incubator-uniffle/pull/599#issuecomment-1429828610
Thanks @xianjingfeng for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #599: [MINOR] chore: remove duplicated dependency in rss-client-mr
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen merged PR #599:
URL: https://github.com/apache/incubator-uniffle/pull/599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org