You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2020/10/20 01:27:48 UTC

[GitHub] [tika] PeterAlfredLee commented on pull request #369: Use IOException instead of IOExceptionWithCause

PeterAlfredLee commented on pull request #369:
URL: https://github.com/apache/tika/pull/369#issuecomment-712531011


   @kkrugler Thank you for reviewing this.
   >I don't see the IOExceptionWithCause class being deprecated
   
   `IOExceptionWithCause` in `Tika` was copying from `commons-io 1.4`. 
   And `IOExceptionWithCause` in `commons-io` has be deprecated since `commons-io 2.5`. see [this](https://github.com/apache/commons-io/blob/aafc3272b38fa51d558f190fbbdac50d62027fdb/src/main/java/org/apache/commons/io/IOExceptionWithCause.java)
   
   > as removing it would be a breaking change
   
   Agree, This will break binary compatibility. And we should only break BC in major version.
   As I see, `main` branch is prepare for `Tika-2.0` which will be the new major version. So I believe this is a good time to break BC.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org