You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by apovzner <gi...@git.apache.org> on 2016/04/06 02:53:19 UTC
[GitHub] kafka pull request: MINOR: ensure original use of prop_file in ver...
GitHub user apovzner opened a pull request:
https://github.com/apache/kafka/pull/1192
MINOR: ensure original use of prop_file in verifiable producer
This PR: https://github.com/apache/kafka/pull/958 fixed the use of prop_file in the situation when we have multiple producers (before, every producer will add to the config). However, it assumes that self.prop_file is initially "". This is correct for all existing tests, but it precludes us from extending verifiable producer and adding more properties to the producer config (same as console consumer). This is a small PR to change the behavior to the original, but keep the fix for multiple producers in verifiable producer.
@granders please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apovzner/kafka fix_verifiable_producer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
----
commit 1ff47c5f64ca22b28b476142a92d7a68966505f5
Author: Anna Povzner <an...@confluent.io>
Date: 2016-04-06T00:45:33Z
MINOR: ensure original use of prop_file in verifiable producer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request: MINOR: ensure original use of prop_file in ver...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---