You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Laszlo Gaal (Jira)" <ji...@apache.org> on 2024/05/27 20:33:00 UTC
[jira] [Resolved] (IMPALA-12886) Bump GoogleTest to 1.14.0 in the toolchain
[ https://issues.apache.org/jira/browse/IMPALA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Laszlo Gaal resolved IMPALA-12886.
----------------------------------
Resolution: Fixed
https://github.com/cloudera/native-toolchain/commit/7daaa07f62a0ad4be1e98777d3e79c1ea60c92df
IMPALA-12886: Bump GoogleTest version to 1.14.0
This is to unblock clang-tidy runs on ARM.
The current version of gtest seems to suffer from a heap corruption
problem that causes unpredictable segfaults in unified-be-tests.
Upgrading to GoogleTest 1.14.0 fixed this problem in test runs, likely
because previously existing global variables have been removed from
GoogleTest's code.
The patch removes the GOOGLETEST_VERSION specifier from the ORC library
build, as unit tests are not built for it.
Change-Id: Iaa52b4809a7c969e863518b182d2df63256f4c43
Reviewed-on: http://gerrit.cloudera.org:8080/21133
Tested-by: Laszlo Gaal <la...@cloudera.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
master
> Bump GoogleTest to 1.14.0 in the toolchain
> ------------------------------------------
>
> Key: IMPALA-12886
> URL: https://issues.apache.org/jira/browse/IMPALA-12886
> Project: IMPALA
> Issue Type: Improvement
> Components: Toolchain
> Affects Versions: Impala 4.4.0
> Reporter: Laszlo Gaal
> Assignee: Laszlo Gaal
> Priority: Major
>
> The current toolchain version of GoogleTest (1.6.0) seems to cause problems during clang-tidy runs happening in precommit test jobs. Recent local tests showed the current version 1.14.0 to be free from this problem. v1.6.0 is also more than 5 years old.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org