You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by nd...@apache.org on 2024/05/23 08:20:29 UTC

(hbase) branch branch-3 updated: HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)

This is an automated email from the ASF dual-hosted git repository.

ndimiduk pushed a commit to branch branch-3
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-3 by this push:
     new 63a2f6e36fa HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)
63a2f6e36fa is described below

commit 63a2f6e36fa7c2cc976601ead39d52e2173f93d3
Author: Nick Dimiduk <nd...@apache.org>
AuthorDate: Wed May 22 10:05:54 2024 +0200

    HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars (#5918)
    
    This change results in this error on master at `3a3dd66e21`.
    
    ```
    [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
    
    Banned imports detected:
    Reason: Use shaded version in hbase-thirdparty
            in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
                    org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
    ```
    
    Signed-off-by: Duo Zhang <zh...@apache.org>
    Signed-off-by: Bryan Beaudreault <bb...@apache.org>
---
 pom.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pom.xml b/pom.xml
index cf502e42d87..9e0eefa039d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2503,6 +2503,7 @@
                     <bannedImport>org.apache.commons.cli.**</bannedImport>
                     <bannedImport>org.apache.commons.collections.**</bannedImport>
                     <bannedImport>org.apache.commons.collections4.**</bannedImport>
+                    <bannedImport>org.apache.hadoop.thirdparty.**</bannedImport>
                   </bannedImports>
                 </restrictImports>
                 <restrictImports implementation="de.skuzzle.enforcer.restrictimports.rule.RestrictImports">