[PR] NIFI-13799 Improve Replicated Cluster Response Handling [nifi]

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory opened a new pull request, #9312:
URL: https://github.com/apache/nifi/pull/9312

   # Summary
   
   [NIFI-13799](https://issues.apache.org/jira/browse/NIFI-13799) Improves replicated HTTP response handling for requests to cluster nodes, avoiding potential heap exhaustion when downloading large FlowFiles.
   
   Instead of buffering the entire response body, the updated approach buffers responses with known content length values that are less than 1 MB. For streamed responses with an unknown content length, or large responses, the replication client returns the HTTP response stream. The changes also include a close callback to ensure that the replicated response stream is closed.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-13799 Improve Replicated Cluster Response Handling [nifi]

["markap14 (via GitHub)" <gi...@apache.org>]

markap14 commented on PR #9312:
URL: https://github.com/apache/nifi/pull/9312#issuecomment-2374939560

   Thanks for fixing that @exceptionfactory! Code changes look good, even a little bit of obvious cleanup that was necessary, likely that was missed during some old refactoring :) Was able to run some tests as well, and everything is checking out on my end. +1 will merge to main!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-13799 Improve Replicated Cluster Response Handling [nifi]

["markap14 (via GitHub)" <gi...@apache.org>]

markap14 merged PR #9312:
URL: https://github.com/apache/nifi/pull/9312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org