You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/14 07:56:05 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #5595: buried shardingDatasource and shardingTable metrics.
codecov-io commented on pull request #5595:
URL: https://github.com/apache/shardingsphere/pull/5595#issuecomment-628461658
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5595?src=pr&el=h1) Report
> Merging [#5595](https://codecov.io/gh/apache/shardingsphere/pull/5595?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e118f1fbb681a81026bea38e850d423b4b61d48d&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5595?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5595 +/- ##
============================================
+ Coverage 56.17% 56.18% +0.01%
Complexity 429 429
============================================
Files 1139 1137 -2
Lines 19997 19994 -3
Branches 3674 3673 -1
============================================
+ Hits 11233 11234 +1
+ Misses 8090 8086 -4
Partials 674 674
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5595?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cs/prometheus/PrometheusMetricsTrackerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljc1RyYWNrZXJGYWN0b3J5LmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...unter/ShardingDatasourceCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvU2hhcmRpbmdEYXRhc291cmNlQ291bnRlck1ldHJpY3NUcmFja2VyLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...pl/counter/ShardingTableCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvU2hhcmRpbmdUYWJsZUNvdW50ZXJNZXRyaWNzVHJhY2tlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...shardingsphere/metrics/enums/MetricsLabelEnum.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9lbnVtcy9NZXRyaWNzTGFiZWxFbnVtLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/shardingproxy/backend/metrics/MetricsUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL21ldHJpY3MvTWV0cmljc1V0aWxzLmphdmE=) | `61.11% <100.00%> (+2.28%)` | `0.00 <0.00> (ø)` | |
| [...ing/boot/OrchestrationSpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmcvc2hhcmRpbmctamRiYy1vcmNoZXN0cmF0aW9uLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL3NwcmluZy9ib290L09yY2hlc3RyYXRpb25TcHJpbmdCb290Q29uZmlndXJhdGlvbi5qYXZh) | `87.09% <0.00%> (-0.41%)` | `0.00% <0.00%> (ø%)` | |
| [...rdingjdbc/spring/boot/SpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLWJvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9ib290L1NwcmluZ0Jvb3RDb25maWd1cmF0aW9uLmphdmE=) | `83.33% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...arding/SpringBootRulesConfigurationProperties.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLWJvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9ib290L3NoYXJkaW5nL1NwcmluZ0Jvb3RSdWxlc0NvbmZpZ3VyYXRpb25Qcm9wZXJ0aWVzLmphdmE=) | | | |
| [...ing/boot/sharding/ShardingSphereRuleCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLWJvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9ib290L3NoYXJkaW5nL1NoYXJkaW5nU3BoZXJlUnVsZUNvbmRpdGlvbi5qYXZh) | | | |
| [...rding/SpringBootRuleConfigurationsYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLWJvb3Qtc3RhcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9ib290L3NoYXJkaW5nL1NwcmluZ0Jvb3RSdWxlQ29uZmlndXJhdGlvbnNZYW1sU3dhcHBlci5qYXZh) | | | |
| ... and [13 more](https://codecov.io/gh/apache/shardingsphere/pull/5595/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5595?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5595?src=pr&el=footer). Last update [e118f1f...5dad119](https://codecov.io/gh/apache/shardingsphere/pull/5595?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org