You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 06:13:11 UTC
[GitHub] [airflow] yuqian90 opened a new pull request #10421: SkipMixin: Add missing session.commit() and test
yuqian90 opened a new pull request #10421:
URL: https://github.com/apache/airflow/pull/10421
I don't know the reason, but if we omit the `session.commit()` that I just added, `test_skip_all_except` fails because task3 state is None instead of SKIPPED. I think it's an issue with sqlalchemy or sqlite and not much to do with Airflow itself.
(NOTE: The impact of this bug being fixed here is pretty minimal and hard to catch because even though this line does not set the state to SKIPPED, the newly introduced `NotPreviouslySkippedDep` actually causes the scheduler to skip the task that are supposed to be skipped. So to the user, this bug being fixed here had almost no impact other than in some test cases. But this session.commit() is needed in case in the future someone calls `skip_all_except()` and expects the state to be set to SKIPPED for the skipped tests).
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yuqian90 commented on pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on pull request #10421:
URL: https://github.com/apache/airflow/pull/10421#issuecomment-677268239
Hi @Kaxil this bug affects `1.10.12rc3` (even though it's a pretty minor issue). I'm hoping this can be merged into both master and the upcoming 1.10.12 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10421:
URL: https://github.com/apache/airflow/pull/10421#issuecomment-677384526
The reason is this: https://github.com/apache/airflow/blob/master/airflow/models/xcom.py#L101 . The xcpm_push method performs "expunge_all()" which removes all modified object from the session. Not sure why though :)
@kaxill - I believe it''s not a case for 1.10.12rc4, but we should definitely merge it if there are other changes. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10421:
URL: https://github.com/apache/airflow/pull/10421#issuecomment-677538276
I would say this can wait for 1.10.13. If we have a major bug report (hopefully not 🤞 ) for 1.10.12rc3 -- then we can include this for rc4 -- but I seriously hope not :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10421:
URL: https://github.com/apache/airflow/pull/10421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10421:
URL: https://github.com/apache/airflow/pull/10421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yuqian90 commented on pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on pull request #10421:
URL: https://github.com/apache/airflow/pull/10421#issuecomment-677413119
> The reason is this: https://github.com/apache/airflow/blob/master/airflow/models/xcom.py#L101 . The xcom_push method performs "expunge_all()" which removes all modified object from the session. Not sure why though :)
>
> @kaxill - I believe it''s not a case for 1.10.12rc4, but we should definitely merge it if there are other changes. :)
I see. Thanks @potiuk for pointing out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #10421:
URL: https://github.com/apache/airflow/pull/10421#issuecomment-677384526
The reason is this: https://github.com/apache/airflow/blob/master/airflow/models/xcom.py#L101 . The xcom_push method performs "expunge_all()" which removes all modified object from the session. Not sure why though :)
@kaxill - I believe it''s not a case for 1.10.12rc4, but we should definitely merge it if there are other changes. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10421: SkipMixin: Add missing session.commit() and test
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10421:
URL: https://github.com/apache/airflow/pull/10421#issuecomment-677807325
Marked it as 1.10.13 then :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org