You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/10/16 05:06:33 UTC
[GitHub] purplecabbage commented on a change in pull request #271: CB-7179
(iOS): Add WKWebView support for iOS
purplecabbage commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r223758316
##########
File path: tests/plugin.xml
##########
@@ -29,5 +29,12 @@
<js-module src="tests.js" name="tests">
</js-module>
+ <platform name="ios">
+ <!-- The WKWebView implementation for inappbrowser requires the presence of this plugin -->
+ <dependency id="cordova-plugin-wkwebview-engine" />
+ <dependency id="cordova-plugin-wkwebview-engine-allowfileaccess" url="https://github.com/knight9999/cordova-plugin-wkwebview-engine-allowfileaccess.git" />
Review comment:
We can’t have this dependency, even in a test ... what if knight9999 makes a commit to master? It could break our tests ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org