[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2877: [#2876][Fix]: JSON string cannot be accurately verified

["wolfboys (via GitHub)" <gi...@apache.org>]

wolfboys commented on code in PR #2877:
URL: https://github.com/apache/incubator-streampark/pull/2877#discussion_r1285208493


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/util/JacksonUtils.java:
##########
@@ -38,7 +38,7 @@ private JacksonUtils() {}
   static {
     MAPPER = new ObjectMapper();
     MAPPER.registerModule(new DefaultScalaModule());
-    MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+    MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, true);

Review Comment:
   This method is used in many places, and changing this parameter could potentially cause other bugs. Unless it has undergone thorough testing, can you explain why it is necessary to change this parameter?



##########
streampark-console/streampark-console-service/src/main/resources/application.yml:
##########
@@ -16,7 +16,7 @@
 #
 
 server:
-  port: 10000
+  port: 10001

Review Comment:
   Why change the port, can you tell us the reason?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org