You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/05/02 16:34:42 UTC

[GitHub] ricellis opened a new pull request #87: 63 update engine

ricellis opened a new pull request #87: 63 update engine
URL: https://github.com/apache/couchdb-nano/pull/87
 
 
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   Updated the minimum Node.js engine in `package.json` to 6. This is currently the oldest available LTS release of Node.js. Moving to a Node.js version >4 unblocks upgrades of `request` to versions > 2.81.0 so the workaround from fc794b202bd68bef785564b35f3071b418215fcb to pin to 2.81.0 can be safely removed (although it appears that #73 already moved it to 2.83.0). With Node.js 6 it should be safe to move back to backwards compatible changes.
   
   ## Testing recommendations
   
   `npm install` will give a warning on Node.js versions older than 6.
   
   ## GitHub issue number
   
   #63 
   
   ## Checklist
   
   - [x] Code is written and works correctly; - No new code `package.json` and `request` dependency version change only.
   - [x] Changes are covered by tests; - tests pass locally for me.
   - [x] Documentation reflects the changes; - updated `README` to mention the minimum version.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services